You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2015/11/29 03:57:03 UTC
Review Request 40783: AMBARI-14108 AMS Collector does not start with
2.1.2 input and env scripts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40783/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-14108
https://issues.apache.org/jira/browse/AMBARI-14108
Repository: ambari
Description
-------
PROBLEM
Ams collector does not startup because of ams-env.sh issues.
BUG
When the "metrics_collector_heapsize" property in ams-env is given a value of "512m" using blueprints, we do not trim the "m" suffix. The ams-env content template adds another "m" causing the startup to fail.
FIX
Added the trimming logic of ams hbase heapsize properties to metrics_collector_heapsize property as well as the deprecated regionserver_xmn_max property as well.
Diffs
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 85e9cb3
Diff: https://reviews.apache.org/r/40783/diff/
Testing
-------
Manually tested on local cluster.
Python Unit tests pass.
Submitted patch through Apache.
Thanks,
Aravindan Vijayan
Re: Review Request 40783: AMBARI-14108 AMS Collector does not start
with 2.1.2 input and env scripts
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40783/#review108262
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On Nov. 29, 2015, 2:57 a.m., Aravindan Vijayan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40783/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2015, 2:57 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-14108
> https://issues.apache.org/jira/browse/AMBARI-14108
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM
> Ams collector does not startup because of ams-env.sh issues.
>
> BUG
> When the "metrics_collector_heapsize" property in ams-env is given a value of "512m" using blueprints, we do not trim the "m" suffix. The ams-env content template adds another "m" causing the startup to fail.
>
> FIX
> Added the trimming logic of ams hbase heapsize properties to metrics_collector_heapsize property as well as the deprecated regionserver_xmn_max property as well.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 85e9cb3
>
> Diff: https://reviews.apache.org/r/40783/diff/
>
>
> Testing
> -------
>
> Manually tested on local cluster.
>
> Python Unit tests pass.
>
> Submitted patch through Apache.
>
>
> Thanks,
>
> Aravindan Vijayan
>
>