You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by watermen <gi...@git.apache.org> on 2015/04/21 05:50:50 UTC
[GitHub] spark pull request: [SPARK-7024][SQL] Improve performance of funct...
GitHub user watermen opened a pull request:
https://github.com/apache/spark/pull/5602
[SPARK-7024][SQL] Improve performance of function containsStar.
The function before will calculate at least `expression.size` times.
The function after will calculate at least `1` times.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/watermen/spark SPARK-7024
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5602.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5602
----
commit 6f3dbea118d835d7b6743774bf6f704147190f70
Author: Yadong Qi <qi...@gmail.com>
Date: 2015-04-21T03:33:43Z
improve performance of containsStar.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7024][SQL] Improve performance of funct...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5602#issuecomment-94630723
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7024][SQL] Improve performance of funct...
Posted by watermen <gi...@git.apache.org>.
Github user watermen closed the pull request at:
https://github.com/apache/spark/pull/5602
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7024][SQL] Improve performance of funct...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5602#issuecomment-94958505
Please avoid making no-op changes in non-performance critical parts of the code, unless you have a benchmark that shows its will actually improve performance. We are very limited in the amount of time we have to review code and these kinds of PRs make it difficult for us to keep up with the request rate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org