You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/05 23:55:46 UTC

[GitHub] [incubator-superset] willbarrett opened a new pull request #8512: Disable deprecated druid connector by default

willbarrett opened a new pull request #8512: Disable deprecated druid connector by default
URL: https://github.com/apache/incubator-superset/pull/8512
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   I've been informed by @mistercrunch that the Druid connector is deprecated in favor of the Druid SQLAlchemy engine. After a recent PR ( #8482 ) re-enabled the function of the `DRUID_IS_ACTIVE` flag, I figured I'd follow through and enshrine the deprecation in code by defaulting `DRUID_IS_ACTIVE` to `False`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [X] Removes existing feature or API (only by default, can be re-enabled)
   
   ### REVIEWERS
   @mistercrunch @dpgaspar @betodealmeida

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org