You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lukecwik (via GitHub)" <gi...@apache.org> on 2023/01/31 23:48:21 UTC
[GitHub] [beam] lukecwik opened a new pull request, #25245: Optimize to use cached output receiver instead of creating one on DoFn invocation #21250
lukecwik opened a new pull request, #25245:
URL: https://github.com/apache/beam/pull/25245
This shows up whenever transforms use output receivers. For example map/flatmap where the calls are expected to be really inexpensive so we don't want to take on the overhead of creating an object.
We saw a small performance improvement overall but best overall was that we reduced the size of the stack by 1 in these scenarios:
Before:
```
Benchmark Mode Cnt Score Error Units
ProcessBundleBenchmark.testLargeBundle thrpt 15 3147.619 ± 130.414 ops/s
```
After:
```
Benchmark Mode Cnt Score Error Units
ProcessBundleBenchmark.testLargeBundle thrpt 15 3251.226 ± 138.822 ops/s
```
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #25245: Optimize to use cached output receiver instead of creating one on DoFn invocation #21250
Posted by "lukecwik (via GitHub)" <gi...@apache.org>.
lukecwik commented on PR #25245:
URL: https://github.com/apache/beam/pull/25245#issuecomment-1411500748
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #25245: Optimize to use cached output receiver instead of creating one on DoFn invocation #21250
Posted by "lukecwik (via GitHub)" <gi...@apache.org>.
lukecwik commented on PR #25245:
URL: https://github.com/apache/beam/pull/25245#issuecomment-1411499828
Run Java_Kafka_IO_Direct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #25245: Optimize to use cached output receiver instead of creating one on DoFn invocation #21250
Posted by "lukecwik (via GitHub)" <gi...@apache.org>.
lukecwik commented on PR #25245:
URL: https://github.com/apache/beam/pull/25245#issuecomment-1411501625
Run Java_Kafka_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #25245: Optimize to use cached output receiver instead of creating one on DoFn invocation #21250
Posted by "lukecwik (via GitHub)" <gi...@apache.org>.
lukecwik commented on PR #25245:
URL: https://github.com/apache/beam/pull/25245#issuecomment-1414046838
Run Java_Kafka_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #25245: Optimize to use cached output receiver instead of creating one on DoFn invocation #21250
Posted by "lukecwik (via GitHub)" <gi...@apache.org>.
lukecwik commented on PR #25245:
URL: https://github.com/apache/beam/pull/25245#issuecomment-1411228244
R: @bhisevishal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik merged pull request #25245: Optimize to use cached output receiver instead of creating one on DoFn invocation #21250
Posted by "lukecwik (via GitHub)" <gi...@apache.org>.
lukecwik merged PR #25245:
URL: https://github.com/apache/beam/pull/25245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #25245: Optimize to use cached output receiver instead of creating one on DoFn invocation #21250
Posted by "lukecwik (via GitHub)" <gi...@apache.org>.
lukecwik commented on PR #25245:
URL: https://github.com/apache/beam/pull/25245#issuecomment-1411499685
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #25245: Optimize to use cached output receiver instead of creating one on DoFn invocation #21250
Posted by "lukecwik (via GitHub)" <gi...@apache.org>.
lukecwik commented on PR #25245:
URL: https://github.com/apache/beam/pull/25245#issuecomment-1414046636
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org