You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/08/05 16:28:37 UTC
[GitHub] [storm] agresch commented on a change in pull request #3320: [STORM-3684] use real compId instead of constant _system for receive-queue V2 metrics
agresch commented on a change in pull request #3320:
URL: https://github.com/apache/storm/pull/3320#discussion_r465851962
##########
File path: storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerState.java
##########
@@ -717,11 +718,19 @@ private Assignment getLocalAssignment(IStormClusterState stormClusterState, Stri
IWaitStrategy backPressureWaitStrategy = IWaitStrategy.createBackPressureWaitStrategy(topologyConf);
Map<List<Long>, JCQueue> receiveQueueMap = new HashMap<>();
+
for (List<Long> executor : executors) {
List<Integer> taskIds = StormCommon.executorIdToTasks(executor);
+ int taskId = taskIds.get(0);
+ String compId;
+ if (taskId == Constants.SYSTEM_TASK_ID) {
+ compId = Constants.SYSTEM_COMPONENT_ID;
Review comment:
Should StormCommon.stormTaskInfo() be addressing this mapping?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org