You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by andreaturli <gi...@git.apache.org> on 2016/09/09 08:13:31 UTC
[GitHub] brooklyn-client pull request #25: move rest-client to brooklyn-client
GitHub user andreaturli opened a pull request:
https://github.com/apache/brooklyn-client/pull/25
move rest-client to brooklyn-client
See also https://github.com/apache/brooklyn-server/pull/325 , merge them in tandem, if ok.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andreaturli/brooklyn-client move/rest-client-to-brooklyn-client
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-client/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit ea4177cd9aef3e7afe9fd049b69588720a3efdf9
Author: Andrea Turli <an...@gmail.com>
Date: 2016-09-07T16:07:07Z
move rest-client to brooklyn-client
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client pull request #25: move rest-client to brooklyn-client
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-client/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the issue:
https://github.com/apache/brooklyn-client/pull/25
@geomacy, I think `brooklyn-client` may be the home for multiple brooklyn clients. I think the `go cli` is just one (the preferred one!), `java` is another one, and ideally we could have rest clients for more languages. I guess I'm interpreting that project as `brooklyn-clients`, sounds wrong to you guys?
we could move the java rest client elsewhere, but is it worth?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-client/pull/25
interesting discussion on mailing list but seems like consensus is to go with what you've originally done here @andreaturli
merge away!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/25
yes, definitely worth discussing there, thanks @andreaturli
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/25
@andreaturli you'll need to update the README.md to reflect the new location of the Go code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/25
the `resteasy` issue is its own thing, we should fix that in brooklyn-server, or, if moving the code is the right solution, fair enough, but I don't think this is the right place to move it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the issue:
https://github.com/apache/brooklyn-client/pull/25
I see your good point, @geomacy
Let's discuss it more broadly, then. I'll ask the mailing list, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/25
@andreaturli what's the reason for this? I think it would be better to keep the `br` CLI as a separate, Go, project, and not add in unrelated code. If there's some reason why the rest client needs to be moved away from brooklyn-server let's move it somewhere independent. I don't think the Go project is the right place for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the issue:
https://github.com/apache/brooklyn-client/pull/25
As for the reason: `brooklyn-server` has a dependency on `resteasy` which is used only by the `rest/rest-client` module. Having `resteasy` and `cxf` (2 jax-rs implementations) in the classpath looks redundant, not considering the extra work needed to support osgi bundles for both. Notice also jaxrs implementation are not really osgi-friendly (ask @googlielmo and @neykov for more details :P) so I think a diet for `brooklyn-server` is not a bad thing :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-client issue #25: move rest-client to brooklyn-client
Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:
https://github.com/apache/brooklyn-client/pull/25
It just feels wrong to me from the "keep things decoupled" / "do one thing" viewpoint. If I am a Go developer I might want to contribute to the brooklyn-client, but if I have no Java background as well I will be put off by all that Java. Adding the REST client here mixes together two completely different technologies in one project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---