You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "tobim (via GitHub)" <gi...@apache.org> on 2023/02/18 14:02:20 UTC

[GitHub] [thrift] tobim opened a new pull request, #2760: Fix Security Tests for OpenSSLv3

tobim opened a new pull request, #2760:
URL: https://github.com/apache/thrift/pull/2760

   OpenSSLv3 does stricter protocol matching in the handshake.
   
   This change adapts the test matrix to work with either both widespread versions of OpenSSL.
   
   Partially fixes [THRIFT-5672](https://issues.apache.org/jira/browse/THRIFT-5672).
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [ ] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2760: Fix Security Tests for OpenSSLv3

Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #2760:
URL: https://github.com/apache/thrift/pull/2760#issuecomment-1455090536

   @tobim 
   
   > C:\projects\thrift\lib\cpp\test\SecurityTest.cpp(223): error C2065: 'OPENSSL_VERSION_MAJOR': undeclared identifier [C:\projects\build\MSVC2017\x64\lib\cpp\test\SecurityTest.vcxproj]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G merged pull request #2760: Fix Security Tests for OpenSSLv3

Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #2760:
URL: https://github.com/apache/thrift/pull/2760


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] tobim commented on pull request #2760: Fix Security Tests for OpenSSLv3

Posted by "tobim (via GitHub)" <gi...@apache.org>.
tobim commented on PR #2760:
URL: https://github.com/apache/thrift/pull/2760#issuecomment-1455092638

   I guess this define is included in the prepocessed source by default on linux/unix but not on msvc. `#include <openssl/opensslv.h>` in both files should fix it, but I don't have access to that platform right now so I can't test it.
   
   Docs are at: https://www.openssl.org/docs/man3.0/man3/OPENSSL_version_major.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2760: Fix Security Tests for OpenSSLv3

Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #2760:
URL: https://github.com/apache/thrift/pull/2760#issuecomment-1435940201

   Thanks! 
   
   While we're at it ... why do we need that same matrix twice? Any possibility to consolidate that into just one easily? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2760: Fix Security Tests for OpenSSLv3

Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #2760:
URL: https://github.com/apache/thrift/pull/2760#issuecomment-1456987029

   > Docs are at: https://www.openssl.org/docs/man3.0/man3/OPENSSL_version_major.html
   
   Tests are at: https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/46410992/job/mhmu1h5fghb3snpk
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org