[jira] [Work logged] (GOBBLIN-1728) Yarn Service requests too many containers due to improper calculation

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1728?focusedWorklogId=818244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818244 ]

ASF GitHub Bot logged work on GOBBLIN-1728:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Oct/22 23:13
            Start Date: 18/Oct/22 23:13
    Worklog Time Spent: 10m 
      Work Description: homatthew opened a new pull request, #3586:
URL: https://github.com/apache/gobblin/pull/3586

   Due to race condition and incorrect API call, the yarn service both allocates too many containers and in rare cases has a discrepancy between the number of containers state due to race conditions.
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 818244)
    Remaining Estimate: 0h
            Time Spent: 10m

> Yarn Service requests too many containers due to improper calculation
> ---------------------------------------------------------------------
>
>                 Key: GOBBLIN-1728
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1728
>             Project: Apache Gobblin
>          Issue Type: New Feature
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Yarn Service is responsible for calculating the number of instances based on the helix tasks. Yarn service tracks the number of instances by asking Yarn for the number of resource requests and the number of allocated containers.
>  
> It uses this count to determine if it should ask for more containers or shrink the number of containers. This calculation is currently done improperly and we continue to request containers when we have enough requested.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)