You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/13 09:09:00 UTC
[jira] [Updated] (FLINK-14720) Bring down
ExecutionVertex#deployToSlot access modifier and mark it with
@VisibleForTesting annotation
[ https://issues.apache.org/jira/browse/FLINK-14720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated FLINK-14720:
-----------------------------------
Labels: pull-request-available (was: )
> Bring down ExecutionVertex#deployToSlot access modifier and mark it with @VisibleForTesting annotation
> ------------------------------------------------------------------------------------------------------
>
> Key: FLINK-14720
> URL: https://issues.apache.org/jira/browse/FLINK-14720
> Project: Flink
> Issue Type: Improvement
> Reporter: vinoyang
> Assignee: vinoyang
> Priority: Minor
> Labels: pull-request-available
>
> From tracking the call chain of {{ExecutionVertex#deployToSlot}}, it seems this method is only been called in the test code. IMO, we'd better bring down {{ExecutionVertex#deployToSlot}} access modifier and mark it with @VisibleForTesting annotation to reduce the risk of incorrect calls
--
This message was sent by Atlassian Jira
(v8.3.4#803005)