You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/20 21:32:56 UTC

[GitHub] [arrow-adbc] kou commented on a diff in pull request #255: ci: run packaging builds on PRs

kou commented on code in PR #255:
URL: https://github.com/apache/arrow-adbc/pull/255#discussion_r1053769340


##########
ci/linux-packages/Rakefile:
##########
@@ -38,7 +38,7 @@ module Helper
     version_env = ENV["VERSION"]
     return version_env if version_env
 
-    meson_build = top_source_dir / "c" / "cmake_modules" / "AdbcDefines.cmake"
+    meson_build = top_source_dir / "c" / "cmake_modules" / "AdbcVersion.cmake"

Review Comment:
   Oh, thanks!



##########
.github/workflows/packaging.yml:
##########
@@ -18,10 +18,23 @@
 name: Packaging
 
 on:
+  pull_request:
+    branches:
+      - main
+    paths:
+      - "adbc.h"
+      - "c/**"
+      - "ci/**"
+      - "glib/**"
+      - "python/**"
+      - "ruby/**"
+      - ".github/workflows/packaging.yml"
+
   push:
     # Automatically build on RC tags
     branches-ignore:
       - '**'
+

Review Comment:
   Is this mistake?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org