You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "jerry-024 (via GitHub)" <gi...@apache.org> on 2025/11/11 10:02:26 UTC

[PR] [core] format table: insert data after commit sync partitions to hms [paimon]

jerry-024 opened a new pull request, #6584:
URL: https://github.com/apache/paimon/pull/6584

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #xxx
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] format table: insert data after commit sync partitions to hms [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #6584:
URL: https://github.com/apache/paimon/pull/6584


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] format table: insert data after commit sync partitions to hms [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6584:
URL: https://github.com/apache/paimon/pull/6584#discussion_r2532441528


##########
paimon-core/src/main/java/org/apache/paimon/catalog/CatalogUtils.java:
##########
@@ -239,7 +239,7 @@ public static Table loadTable(
         Function<Path, FileIO> dataFileIO = metadata.isExternal() ? externalFileIO : internalFileIO;
 
         if (options.type() == TableType.FORMAT_TABLE) {
-            return toFormatTable(identifier, schema, dataFileIO);
+            return toFormatTable(identifier, schema, dataFileIO, catalog.catalogContext());

Review Comment:
   Already has parameter `catalogContext`...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] format table: insert data after commit sync partitions to hms [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6584:
URL: https://github.com/apache/paimon/pull/6584#discussion_r2525729549


##########
paimon-api/src/main/java/org/apache/paimon/CoreOptions.java:
##########
@@ -2030,6 +2030,16 @@ public InlineElement getDescription() {
                     .noDefaultValue()
                     .withFallbackKeys(FILE_COMPRESSION.key())
                     .withDescription("Format table file compression.");
+    public static final ConfigOption<String> FORMAT_TABLE_COMMIT_SYNC_PARTITION_HIVE_URI =
+            ConfigOptions.key("format-table.commit.sync-partition-hive.uri")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDescription("Format table commit sync partition hive uri.");
+    public static final ConfigOption<String> FORMAT_TABLE_COMMIT_SYNC_PARTITION_HIVE_WAREHOUSE =

Review Comment:
   warehouse is useless, remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] format table: insert data after commit sync partitions to hms [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6584:
URL: https://github.com/apache/paimon/pull/6584#discussion_r2532440186


##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -548,6 +548,12 @@
             <td>Boolean</td>
             <td>Whether to force the use of lookup for compaction.</td>
         </tr>
+        <tr>
+            <td><h5>format-table.commit.sync-partition-hive.uri</h5></td>

Review Comment:
   `format-table.commit-hive-sync-url`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org