You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/12/01 06:46:15 UTC
Re: [PR] feat: alerts and reports modal with dashboard filters and tabs [WIP] [superset]
codecov[bot] commented on PR #26141:
URL: https://github.com/apache/superset/pull/26141#issuecomment-1835557309
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `54 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`4f00404`)](https://app.codecov.io/gh/apache/superset/commit/4f004048054776c3074dfa5b4d5fd684cced47f1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.13% compared to head [(`9476ec1`)](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.08%.
| [Files](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ures/alerts/components/DashboardFiltersAndTabs.tsx](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2FsZXJ0cy9jb21wb25lbnRzL0Rhc2hib2FyZEZpbHRlcnNBbmRUYWJzLnRzeA==) | 2.12% | [46 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...-frontend/src/features/alerts/AlertReportModal.tsx](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVzL2FsZXJ0cy9BbGVydFJlcG9ydE1vZGFsLnRzeA==) | 28.57% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | 50.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset-frontend/src/dataMask/actions.ts](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL2FjdGlvbnMudHM=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [superset-frontend/src/dataMask/reducer.ts](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #26141 +/- ##
==========================================
- Coverage 69.13% 69.08% -0.05%
==========================================
Files 1941 1942 +1
Lines 75893 75953 +60
Branches 8450 8468 +18
==========================================
+ Hits 52467 52473 +6
- Misses 21251 21304 +53
- Partials 2175 2176 +1
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/26141/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/26141/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.27% <10.00%> (-0.08%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/26141?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org