[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #2482: [KYUUBI #2419] Destroy the ProcBuilder process and call killApplication during closing session

[GitBox <gi...@apache.org>]

ulysses-you commented on code in PR #2482:
URL: https://github.com/apache/incubator-kyuubi/pull/2482#discussion_r860380855


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala:
##########
@@ -237,12 +237,20 @@ trait ProcBuilder {
     process
   }
 
-  def close(): Unit = synchronized {
+  def close(): Unit = {
+    close(!waitCompletion)
+  }
+
+  def shutdown(): Unit = {

Review Comment:
   We do not need an another method, just
   ```
   def close(destroyForcibly: Boolean = waitCompletion): Unit = {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org