[GitHub] [samza] prateekm commented on a diff in pull request #1658: Changed uses of Apache Commons IO FileUtils.deleteDirectory to PathUtils.deleteDirectory

["prateekm (via GitHub)" <gi...@apache.org>]

prateekm commented on code in PR #1658:
URL: https://github.com/apache/samza/pull/1658#discussion_r1144205654


##########
samza-test/src/test/java/org/apache/samza/storage/kv/BlobStoreStateBackendIntegrationTest.java:
##########
@@ -82,8 +82,16 @@ public static Collection<Boolean> data() {
 
   private static final String IN_MEMORY_STORE_CHANGELOG_TOPIC = "inMemoryStoreChangelog";
 
-  private static final String LOGGED_STORE_BASE_DIR = new File(System.getProperty("java.io.tmpdir"), "logged-store").getAbsolutePath();
-  private static final String BLOB_STORE_BASE_DIR = new File(System.getProperty("java.io.tmpdir"), "blob-store").getAbsolutePath();
+  private static final String LOGGED_STORE_BASE_DIR;
+  private static final String BLOB_STORE_BASE_DIR;
+  static {
+    try {
+      LOGGED_STORE_BASE_DIR = Files.createTempDirectory("logged-store-").toString();

Review Comment:
   This is unrelated cleanup. With this the temp base dir is unique for each test run (createTempDirectory adds a random suffix to the provided prefix).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org