[PR] [FLINK-40086][runtime] Adds error handling to newly added preCompletionAction [flink]

["XComp (via GitHub)" <gi...@apache.org>]

XComp opened a new pull request, #28699:
URL: https://github.com/apache/flink/pull/28699

   ## What is the purpose of the change
   
   FLINK-40076 introduced a slight refactoring to Execution where the accumulators and ioMetrics are updated before completing the `Execution`. This introduced a slight inconsistency, where (theoretically) the `preCompletionAction` can fail and leave the `Execution` in an inconsistent state with the state being terminal but the `terminalFuture` not being completed.
   
   This PR fixes the inconsistency. That said - the issue doesn't exist in the current code base because the only existing `preCompletionAction` only consists of field setters. 
   
   ## Brief change log
   
   * Adds a try/catch around the `preCompletionAction` execution
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable`
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change the checkbox below to `[X]` followed by the name of the tool, and uncomment the
   "Generated-by" line. See the ASF Generative Tooling Guidance for details:
   https://www.apache.org/legal/generative-tooling.html
   
   You are responsible for the quality and correctness of every change in this PR
   regardless of the tooling used. Low-effort AI-generated PRs will be closed. See
   AGENTS.md for the full guidance.
   -->
   
   - [X] Yes (please specify the tool below)
   
   Issue was identified by claude. Code change was done manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-40086][runtime] Adds error handling to newly added preCompletionAction [flink]

["XComp (via GitHub)" <gi...@apache.org>]

XComp merged PR #28699:
URL: https://github.com/apache/flink/pull/28699


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-40086][runtime] Adds error handling to newly added preCompletionAction [flink]

["flinkbot (via GitHub)" <gi...@apache.org>]

flinkbot commented on PR #28699:
URL: https://github.com/apache/flink/pull/28699#issuecomment-4926418157

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "162a021b0f6634ba324c4939466088b1af7e0c67",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "162a021b0f6634ba324c4939466088b1af7e0c67",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 162a021b0f6634ba324c4939466088b1af7e0c67 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org