[GitHub] [flink] akalash commented on pull request #19864: [FLINK-27162][runtime] Trigger non-periodic checkpoint in 'timer' thread

[GitBox <gi...@apache.org>]

akalash commented on PR #19864:
URL: https://github.com/apache/flink/pull/19864#issuecomment-1164341484

   I think we can rethink `triggerCheckpoint` and use it only from one `timer` thread(`main coordinator` thread in the future). Right now, I introduced the second method `triggerCheckpointFromCheckpointThread` because it is simple and it doesn't require a lot of changes but theoretically, we can use only one method `triggerCheckpoint` and if it is called from the non-expected thread(check the name of the thread?) then we can automatically wrap it with required thread(the same logic as we use in mailbox). Or at least we should check the condition that the `triggerCheckpoint` is called from the expected thread but it requires many changes in tests since many tests call this method directly from main test thread right now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org