You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/09/09 09:45:05 UTC
[GitHub] [incubator-uniffle] zuston opened a new issue, #209: [Feature] Introduce the taskId in the spark client side log
zuston opened a new issue, #209:
URL: https://github.com/apache/incubator-uniffle/issues/209
### Motivation
When multiple tasks are running in the same executor at the same time, it will be hard to analysis the rss log belonging to the specified task. To solve this, it's better to make log show task id in the rss client codebase.
### How to do
I think we should directly use the [MDC](https://www.baeldung.com/mdc-in-log4j-2-logback) to put the context info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #209: [Feature] Introduce the taskId in the spark client side log
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #209:
URL: https://github.com/apache/incubator-uniffle/issues/209#issuecomment-1258880952
> It's a little abstraction for me, maybe you can raise a draft pr and let me look at it.
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #209: [Feature] Introduce the taskId in the spark client side log
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #209:
URL: https://github.com/apache/incubator-uniffle/issues/209#issuecomment-1246443729
Could you share me that what are you concerned about most? The cost of refactor or performance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #209: [Feature] Introduce the taskId in the spark client side log
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #209:
URL: https://github.com/apache/incubator-uniffle/issues/209#issuecomment-1246577982
> Could we adjust the log4j to print thread ID?
This way looks a little bit ugly on propagating thread id/ task id in multiple threads when using thread pool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #209: [Feature] Introduce the taskId in the spark client side log
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #209:
URL: https://github.com/apache/incubator-uniffle/issues/209#issuecomment-1251749878
What do u think? @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #209: [Feature] Introduce the taskId in the spark client side log
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #209:
URL: https://github.com/apache/incubator-uniffle/issues/209#issuecomment-1246432071
MDC seems heavy for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] zuston commented on issue #209: [Feature] Introduce the taskId in the spark client side log
Posted by GitBox <gi...@apache.org>.
zuston commented on issue #209:
URL: https://github.com/apache/incubator-uniffle/issues/209#issuecomment-1241753364
What do u think? @jerqi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #209: [Feature] Introduce the taskId in the spark client side log
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #209:
URL: https://github.com/apache/incubator-uniffle/issues/209#issuecomment-1257886807
It's a little abstraction for me, maybe you can raise a draft pr and let me look at it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-uniffle] jerqi commented on issue #209: [Feature] Introduce the taskId in the spark client side log
Posted by GitBox <gi...@apache.org>.
jerqi commented on issue #209:
URL: https://github.com/apache/incubator-uniffle/issues/209#issuecomment-1246573939
Could we adjust the log4j to print thread ID?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org