You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/06 01:39:05 UTC

[GitHub] [airflow] Acehaidrey commented on a change in pull request #8680: Add metric for start/end task run

Acehaidrey commented on a change in pull request #8680:
URL: https://github.com/apache/airflow/pull/8680#discussion_r420502117



##########
File path: airflow/models/taskinstance.py
##########
@@ -1080,6 +1081,8 @@ def signal_handler(signum, frame):
             self.handle_failure(e, test_mode, context)
             raise
 
+        Stats.incr('ti.complete.{}.{}.{}'.format(task.dag_id, task.task_id, self.state), 1, 1)

Review comment:
       change it to finished 
   I do the separation on the `.` because can do different grouping aggregates on statsd/prometheus side vs using the `_`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org