You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/02/23 22:43:57 UTC
Review Request 65785: Added a test for QuotaRequest validation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65785/
-----------------------------------------------------------
Review request for mesos, Michael Park and Meng Zhu.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/master_validation_tests.cpp 77ec7fb37c9b9c168013d1d81ca862617682af6d
Diff: https://reviews.apache.org/r/65785/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 65785: Added a test for QuotaRequest validation.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65785/#review198229
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65334', '65514', '65515', '65780', '65781', '65782', '65783', '65784', '65785']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65785
Relevant logs:
- [stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65785/logs/stout-tests-stdout.log):
```
[ RUN ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile
[ OK ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile (5 ms)
[ RUN ] RmdirTest.RemoveDirectoryButPreserveRoot
[ OK ] RmdirTest.RemoveDirectoryButPreserveRoot (6 ms)
[----------] 11 tests from RmdirTest (62 ms total)
[----------] 1 test from SocketTests
[ RUN ] SocketTests.InitSocket
[ OK ] SocketTests.InitSocket (2 ms)
[----------] 1 test from SocketTests (2 ms total)
[----------] 2 tests from StrerrorTest
[ RUN ] StrerrorTest.ValidErrno
[ OK ] StrerrorTest.ValidErrno (0 ms)
[ RUN ] StrerrorTest.InvalidErrno
[ OK ] StrerrorTest.InvalidErrno (0 ms)
[----------] 2 tests from StrerrorTest (2 ms total)
[----------] Global test environment tear-down
[==========] 273 tests from 46 test cases ran. (5037 ms total)
[ PASSED ] 270 tests.
[ FAILED ] 3 tests, listed below:
[ FAILED ] OsTest.SYMLINK_Realpath
[ FAILED ] FsTest.CreateDirectoryAtMaxPath
[ FAILED ] FsTest.CreateDirectoryLongerThanMaxPath
3 FAILED TESTS
YOU HAVE 7 DISABLED TESTS
```
- [stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65785/logs/stout-tests-stderr.log):
```
'invalid.command' is not recognized as an internal or external command,
operable program or batch file.
Subcommand 'subcommand' is not available
Usage: command <subcommand> [OPTIONS]
Available subcommands:
help
subcommand2
Multiple subcommands have name 'subcommand'
```
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65785/logs/mesos-tests-stdout.log):
```
[----------] 9 tests from Endpoint/SlaveEndpointTest (1151 ms total)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (37 ms)
[ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (43 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (84 ms total)
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2620 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2644 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2585 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2609 ms total)
[----------] Global test environment tear-down
[==========] 912 tests from 90 test cases ran. (477960 ms total)
[ PASSED ] 910 tests.
[ FAILED ] 2 tests, listed below:
[ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout
[ FAILED ] FilesTest.DebugTest
2 FAILED TESTS
YOU HAVE 211 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65785/logs/mesos-tests-stderr.log):
```
I0223 23:54:40.547863 10740 master.cpp:10248] Updating the state of task 67e4097e-2190-45a6-bd93-f2756be81890 of framework ed6b543c-41bd-4cb1-b546-578dd370e8b7-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0223 23:54:40.547863 8928 slave.cpp:3879] Shutting down framework ed6b543c-41bd-4cb1-b546-578dd370e8b7-0000
I0223 23:54:40.548864 8928 slave.cpp:6586] Shutting down executor '67e409I0223 23:54:39.823874 10912 exec.cpp:162] Version: 1.6.0
I0223 23:54:39.853849 4268 exec.cpp:236] Executor registered on agent ed6b543c-41bd-4cb1-b546-578dd370e8b7-S0
I0223 23:54:39.857852 2316 executor.cpp:174] Received SUBSCRIBED event
I0223 23:54:39.862853 2316 executor.cpp:178] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0223 23:54:39.863878 2316 executor.cpp:174] Received LAUNCH event
I0223 23:54:39.867851 2316 executor.cpp:646] Starting task 67e4097e-2190-45a6-bd93-f2756be81890
I0223 23:54:39.951854 2316 executor.cpp:481] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I0223 23:54:40.510931 2316 executor.cpp:659] Forked command at 10280
I0223 23:54:40.551862 5400 exec.cpp:445] Executor asked to shutdown
I0223 23:54:40.552863 2316 executor.cpp:174] Received SHUTDOWN event
I0223 23:54:40.553861 2316 executor.cpp:756] Shutting down
I0223 23:54:40.553861 2316 executor.cpp:866] Sending SIGTERM to process tree at pid 7e-2190-45a6-bd93-f2756be81890' of framework ed6b543c-41bd-4cb1-b546-578dd370e8b7-0000 at executor(1)@10.3.1.11:55233
I0223 23:54:40.550863 8928 slave.cpp:922] Agent terminating
W0223 23:54:40.550863 8928 slave.cpp:3875] Ignoring shutdown framework ed6b543c-41bd-4cb1-b546-578dd370e8b7-0000 because it is terminating
I0223 23:54:40.550863 10740 master.cpp:10347] Removing task 67e4097e-2190-45a6-bd93-f2756be81890 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework ed6b543c-41bd-4cb1-b546-578dd370e8b7-0000 on agent ed6b543c-41bd-4cb1-b546-578dd370e8b7-S0 at slave(396)@10.3.1.11:55212 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0223 23:54:40.553861 10740 master.cpp:1306] Agent ed6b543c-41bd-4cb1-b546-578dd370e8b7-S0 at slave(396)@10.3.1.11:55212 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0223 23:54:40.553861 10740 master.cpp:3276] Disconnecting agent ed6b543c-41bd-4cb1-b546-578dd370e8b7-S0 at slave(396)@10.3.1.11:55212 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0223 23:54:40.554864 2148 containerizer.cpp:2338] Destroying container 3ef10198-1ecb-44fe-bc96-540c94f6ff0c in RUNNING state
I0223 23:54:40.554864 6236 hierarchical.cpp:344] Removed framework ed6b543c-41bd-4cb1-b546-578dd370e8b7-0000
I0223 23:54:40.554864 10740 master.cpp:3295] Deactivating agent ed6b543c-41bd-4cb1-b546-578dd370e8b7-S0 at slave(396)@10.3.1.11:55212 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0223 23:54:40.554864 2148 containerizer.cpp:2952] Transitioning the state of container 3ef10198-1ecb-44fe-bc96-540c94f6ff0c from RUNNING to DESTROYING
I0223 23:54:40.555861 10108 hierarchical.cpp:766] Agent ed6b543c-41bd-4cb1-b546-578dd370e8b7-S0 deactivated
I0223 23:54:40.556886 2148 launcher.cpp:156] Asked to destroy container 3ef10198-1ecb-44fe-bc96-540c94f6ff0c
I0223 23:54:40.639889 2684 containerizer.cpp:2791] Container 3ef10198-1ecb-44fe-bc96-540c94f6ff0c has exited
I0223 23:54:40.672888 7556 master.cpp:1149] Master terminating
I0223 23:54:40.675889 6236 hierarchical.cpp:609] Removed agent ed6b543c-41bd-4cb1-b546-578dd370e8b7-S0
I0223 23:54:41.324925 2892 process.cpp:929] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Feb. 23, 2018, 10:43 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65785/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2018, 10:43 p.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 77ec7fb37c9b9c168013d1d81ca862617682af6d
>
>
> Diff: https://reviews.apache.org/r/65785/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 65785: Added a test for QuotaRequest validation.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65785/#review198244
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65334, 65514, 65515, 65780, 65781, 65782, 65783, 65784, 65785]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 23, 2018, 2:43 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65785/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2018, 2:43 p.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 77ec7fb37c9b9c168013d1d81ca862617682af6d
>
>
> Diff: https://reviews.apache.org/r/65785/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 65785: Added a test for QuotaRequest validation.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65785/#review202241
-----------------------------------------------------------
Ship it!
Ship It!
src/tests/master_validation_tests.cpp
Lines 268 (patched)
<https://reviews.apache.org/r/65785/#comment283992>
To me it is simpler to think that "guarantee <= limit" is still a resourceS wise check. But the default guarantee value is zero while default limit value is infinite.
- Meng Zhu
On Feb. 23, 2018, 2:43 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65785/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2018, 2:43 p.m.)
>
>
> Review request for mesos, Michael Park and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 77ec7fb37c9b9c168013d1d81ca862617682af6d
>
>
> Diff: https://reviews.apache.org/r/65785/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>