[GitHub] [solr] dsmiley commented on a change in pull request #583: SOLR-14686: fix MDC log clear in SolrCore.close

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #583:
URL: https://github.com/apache/solr/pull/583#discussion_r797276346



##########
File path: solr/core/src/java/org/apache/solr/core/SolrCore.java
##########
@@ -1573,13 +1573,20 @@ public void open() {
    */
   @Override
   public void close() {
-    int count = refCount.decrementAndGet();
-    if (count > 0) return; // close is called often, and only actually closes if nothing is using it.

Review comment:
       The javadocs on this method are excellent though, so it seemed redundant




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org