[GitHub] [avro] jklamer commented on a change in pull request #1602: [AVRO-3448][rust] Rust name/namespace spec adherence work

[GitBox <gi...@apache.org>]

jklamer commented on a change in pull request #1602:
URL: https://github.com/apache/avro/pull/1602#discussion_r826436474



##########
File path: lang/rust/avro/src/schema.rs
##########
@@ -225,30 +228,31 @@ impl<'a> From<&'a types::Value> for SchemaKind {
 ///
 /// More information about schema names can be found in the
 /// [Avro specification](https://avro.apache.org/docs/current/spec.html#names)
-#[derive(Clone, Debug, Deserialize)]
+#[derive(Clone, Debug, Deserialize, Hash, PartialEq, Eq)]
 pub struct Name {
     pub name: String,
-    pub namespace: Option<String>,
-    pub aliases: Option<Vec<String>>,
+    pub namespace: Namespace,
 }
 
 /// Represents documentation for complex Avro schemas.
 pub type Documentation = Option<String>;
+/// Represents the aliases for Named Schema
+pub type Aliases = Option<Vec<String>>;
+/// Represents Schema lookup within a schema env
+pub type Names = HashMap<Name, Schema>;

Review comment:
       Probably not? I use the same type inside of latest avro derive and would want to use it there, but thats probably the same crate? (I don't know enough about crate packaging to say for certain). I'll make it pub(crate) and change it if needed in avro derive, but then then the change is then obviously associate with the new out of crate use. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org