You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/04 21:25:23 UTC

[GitHub] [arrow-datafusion] alamb commented on pull request #1922: Add write_csv to DataFrame

alamb commented on pull request #1922:
URL: https://github.com/apache/arrow-datafusion/pull/1922#issuecomment-1059542713


   >  I took the logic for writing csvs and put it in new function plan_to_csv within src/physical_plan/file_format/csv and moved testing there. Then just used that function in both ExecutionContext and DataFrame
   
   Looks good to me 👍 
   
   > currently failing because of the signature of write_csv having impl AsRef<str> which i took from the existing implementation on ExecutionContext but doesnt work because trait object cant have method with generic type parameter. Is there a reason we cant use &str? 
   
   I think taking `&str` is totally fine in the `DataFrame` trait
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org