You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "ShadowySpirits (via GitHub)" <gi...@apache.org> on 2023/04/25 12:13:21 UTC
[GitHub] [rocketmq] ShadowySpirits commented on a diff in pull request #6649: [ISSUE #6648]: Fix the bug that not all message fetch requests are processed via TieredStorage when level is FORCE
ShadowySpirits commented on code in PR #6649:
URL: https://github.com/apache/rocketmq/pull/6649#discussion_r1176423754
##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageStore.java:
##########
@@ -99,6 +99,11 @@ public boolean viaTieredStorage(String topic, int queueId, long offset) {
public boolean viaTieredStorage(String topic, int queueId, long offset, int batchSize) {
TieredMessageStoreConfig.TieredStorageLevel deepStorageLevel = storeConfig.getTieredStorageLevel();
+
+ if (deepStorageLevel.check(TieredMessageStoreConfig.TieredStorageLevel.FORCE)) {
Review Comment:
We should add a comment for the `FORCE` level. It will force `viaTieredStorage` retuning true, but it can not prevent falling back to the default store when failing to fetch messages from tiered storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org