[GitHub] [spark] grundprinzip commented on a diff in pull request #41403: [SPARK-43895][CONNECT][GO] Prepare the go package path

["grundprinzip (via GitHub)" <gi...@apache.org>]

grundprinzip commented on code in PR #41403:
URL: https://github.com/apache/spark/pull/41403#discussion_r1212076040


##########
connector/connect/common/src/main/protobuf/buf.yaml:
##########
@@ -18,6 +18,8 @@ version: v1
 breaking:
   use:
     - FILE
+  except:
+    - FILE_SAME_GO_PACKAGE

Review Comment:
   As you can see above without this option it will be a breaking change compared to the 3.4 release. Since we don't have a go client right now it's acceptable. Once we have the go client and a new release we can remove this again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org