You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/11/30 08:04:09 UTC

[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1028: [CELEBORN-63] Increase push data return reason types such as CONGESTION ect

AngersZhuuuu commented on code in PR #1028:
URL: https://github.com/apache/incubator-celeborn/pull/1028#discussion_r1035641599


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -262,7 +262,7 @@ class PushDataHandler extends BaseMessageHandler with Logging {
         }
       })
     } else {
-      wrappedCallback.onSuccess(ByteBuffer.wrap(Array[Byte]()))
+      wrappedCallback.onSuccess(ByteBuffer.wrap(Array[Byte](StatusCode.SUCCESS_FREE.getValue)))

Review Comment:
   Should not update here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org