You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "summaryzb (via GitHub)" <gi...@apache.org> on 2025/03/14 02:58:16 UTC
[PR] Introduce a new way to support jetty use random port [uniffle]
summaryzb opened a new pull request, #2402:
URL: https://github.com/apache/uniffle/pull/2402
### What changes were proposed in this pull request?
Make it possible to get the actual port when config jetty port to zero
### Why are the changes needed?
Support jetty use random port
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2401] Make it possible to get the actual port when config jetty port to zero [uniffle]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #2402:
URL: https://github.com/apache/uniffle/pull/2402#discussion_r1995071821
##########
common/src/main/java/org/apache/uniffle/common/web/JettyServer.java:
##########
@@ -169,13 +169,15 @@ public Server getServer() {
return this.server;
}
- public void start() throws Exception {
+ public int start() throws Exception {
try {
server.start();
+ httpPort = ((ServerConnector) server.getConnectors()[0]).getLocalPort();
Review Comment:
Is there anything that ensures `server.getConnectors()[0]` is an instance of the `ServerConnector` type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2401] Make it possible to get the actual port when config jetty port to zero [uniffle]
Posted by "summaryzb (via GitHub)" <gi...@apache.org>.
summaryzb commented on code in PR #2402:
URL: https://github.com/apache/uniffle/pull/2402#discussion_r1995223478
##########
common/src/main/java/org/apache/uniffle/common/web/JettyServer.java:
##########
@@ -169,13 +169,15 @@ public Server getServer() {
return this.server;
}
- public void start() throws Exception {
+ public int start() throws Exception {
try {
server.start();
+ httpPort = ((ServerConnector) server.getConnectors()[0]).getLocalPort();
Review Comment:
The type and sort of `ServerConnector` in determined in `JettyServer` initialize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2401] Make it possible to get the actual port when config jetty port to zero [uniffle]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang merged PR #2402:
URL: https://github.com/apache/uniffle/pull/2402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2401] Make it possible to get the actual port when config jetty port to zero [uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2402:
URL: https://github.com/apache/uniffle/pull/2402#issuecomment-2723310214
## Test Results
2 937 files - 59 2 937 suites - 59 6h 11m 11s ⏱️ - 21m 2s
1 105 tests ± 0 1 103 ✅ ± 0 2 💤 ±0 0 ❌ ±0
13 681 runs - 168 13 653 ✅ - 166 28 💤 - 2 0 ❌ ±0
Results for commit c0dce6fd. ± Comparison against base commit 87362fb7.
[test-results]:data:application/gzip;base64,H4sIABah02cC/03MzRLDEBSG4VvJWHdByEFvpqMHM6b56QirTO+9kopm533wbcSH0a3k3vWay1tH1hzStW2OJoVl3qXvJStU7tP+gjE6nPlYM+LP+N9e4b3/a+BNGAvQBi7GJVaJeT5WOShWs61yGHizuqpOuKwefR3FZZpCKkGQWnTgrdCCKgAm/YDlLPVTGSc8BS3QKxDk8wV6/uwiFAEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#2401] Make it possible to get the actual port when config jetty port to zero [uniffle]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #2402:
URL: https://github.com/apache/uniffle/pull/2402#issuecomment-2724213695
Merged into master. Thanks @summaryzb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org