Re: Website, mailing lists page change the search box

[Daniel Sahlberg <da...@gmail.com>]

Den tors 21 jan. 2021 kl 17:58 skrev Daniel Sahlberg <
daniel.l.sahlberg@gmail.com>:

> Den tors 21 jan. 2021 17:16Daniel Shahaf <d....@daniel.shahaf.name> skrev:
>
>> Daniel Sahlberg wrote on Thu, 21 Jan 2021 07:21 +00:00:
>> > Den ons 20 jan. 2021 kl 23:56 skrev Nathan Hartman <
>> hartman.nathan@gmail.com>:
>> > > On Wed, Jan 20, 2021 at 11:16 AM Daniel Shahaf <
>> d.s@daniel.shahaf.name> wrote:
>> > >> How about linking to mail-archives.apache.org, or to a sane third-
>> > >> party archive?  I know lists.a.o is "official" but unless it has
>> > >> changed its spots since I last looked, I'd have zero problems with
>> > >> linking to other archives.  The javascript-wall is just one issue.
>> > >
>> > > The biggest thing that drives me up the wall with lists.a.o is the
>> mile-long URLs. The only reason I use them is because I've heard
>> whisperings that this is ASF's preferred long-term archive and the other
>> one might disappear someday. But I would it be the other way around.
>> >
>> > I have switched to a google site search on mail-archives.a.o. I had to
>> > resort to a javascript hack to add "inurl:subversion" to the search
>> > term, otherwise we would get results from all mailing lists (httpd,
>> > tomcat, ponymail etc.). Side effect is that it shows in the search box
>> > if you go back from google.
>> >
>> > Committed r1885743
>>
>> Thanks, Daniel!
>>
>> If there's a way to make that work without requiring javascript, that'd
>> be great.  If nothing else, presetting the textbox's value to
>> "inurl:subversion" and then removing that in javascript unconditionally
>> might work?
>>
>
> I'm not a web designer, never will be. But according to my searches the
> inurl has to be part of the search string, it can't be passed as a separate
> field in the query string. I'd be happy if I'm proven wrong.
>
> I think it will confuse users to have it as a predefined value in the
> input box. A possible solution would be to have it in the html file, remove
> it with javascript when the document is loaded and the adding it again on
> submit. That way it would work for user without javascript (with a slight
> inconvenience) as well. But how many is that really these days?
>

Finally found some time to look at this again. I've committed r1886109
which:
* Add inurl:subversion as the default value to the textbox.
* Remove it in body.onload.
* Add it again when the form is submitted.

The last two obviously only happen to users with javascript enabled.

Feel free to test it at
https://subversion-staging.apache.org/mailing-lists.html

/Daniel Sahlberg

>

Re: Website, mailing lists page change the search box

[Daniel Sahlberg <da...@gmail.com>]

Den ons 3 feb. 2021 kl 12:07 skrev Daniel Shahaf <d....@daniel.shahaf.name>:

> Daniel Sahlberg wrote on Mon, 01 Feb 2021 21:21 +00:00:
> > Den tors 21 jan. 2021 kl 17:58 skrev Daniel Sahlberg
> > <da...@gmail.com>:
> > > Den tors 21 jan. 2021 17:16Daniel Shahaf <d....@daniel.shahaf.name>
> skrev:
> > >> If there's a way to make that work without requiring javascript,
> that'd
> > >> be great.  If nothing else, presetting the textbox's value to
> > >> "inurl:subversion" and then removing that in javascript
> unconditionally
> > >> might work?
> > >
> > > I'm not a web designer, never will be. But according to my searches
> the inurl has to be part of the search string, it can't be passed as a
> separate field in the query string. I'd be happy if I'm proven wrong.
> > >
> > > I think it will confuse users to have it as a predefined value in the
> input box. A possible solution would be to have it in the html file, remove
> it with javascript when the document is loaded and the adding it again on
> submit. That way it would work for user without javascript (with a slight
> inconvenience) as well. But how many is that really these days?
> >
> > Finally found some time to look at this again. I've committed r1886109
> which:
> > * Add inurl:subversion as the default value to the textbox.
> > * Remove it in body.onload.
> > * Add it again when the form is submitted.
> >
> > The last two obviously only happen to users with javascript enabled.
> >
> > Feel free to test it at
> https://subversion-staging.apache.org/mailing-lists.html
>
> +1, thanks a lot!
>

Merged to publish in r1886187.

https://subversion.apache.org/mailing-lists.html works as expected for me,
please report any issues!

Kind regards,
Daniel Sahlberg

Re: Website, mailing lists page change the search box

[Daniel Shahaf <d....@daniel.shahaf.name>]

Daniel Sahlberg wrote on Mon, 01 Feb 2021 21:21 +00:00:
> Den tors 21 jan. 2021 kl 17:58 skrev Daniel Sahlberg 
> <da...@gmail.com>:
> > Den tors 21 jan. 2021 17:16Daniel Shahaf <d....@daniel.shahaf.name> skrev:
> >> If there's a way to make that work without requiring javascript, that'd
> >> be great.  If nothing else, presetting the textbox's value to
> >> "inurl:subversion" and then removing that in javascript unconditionally
> >> might work?
> > 
> > I'm not a web designer, never will be. But according to my searches the inurl has to be part of the search string, it can't be passed as a separate field in the query string. I'd be happy if I'm proven wrong. 
> > 
> > I think it will confuse users to have it as a predefined value in the input box. A possible solution would be to have it in the html file, remove it with javascript when the document is loaded and the adding it again on submit. That way it would work for user without javascript (with a slight inconvenience) as well. But how many is that really these days?
> 
> Finally found some time to look at this again. I've committed r1886109 which:
> * Add inurl:subversion as the default value to the textbox.
> * Remove it in body.onload.
> * Add it again when the form is submitted.
> 
> The last two obviously only happen to users with javascript enabled.
> 
> Feel free to test it at https://subversion-staging.apache.org/mailing-lists.html

+1, thanks a lot!

Daniel