You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/03/07 20:38:50 UTC
Review Request 44463: Made `timer.hpp` header self-contained.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44463/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Repository: mesos
Description
-------
The `timer.hpp` was missing an include for `pid.hpp` required for accessing `process::UPID`
Diffs
-----
3rdparty/libprocess/include/process/timer.hpp 6bf7216ab3994044faaf92c865b5324b89330106
Diff: https://reviews.apache.org/r/44463/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 44463: Made `timer.hpp` header self-contained.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44463/#review122406
-----------------------------------------------------------
Patch looks great!
Reviews applied: [44463]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 7, 2016, 7:38 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44463/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 7:38 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `timer.hpp` was missing an include for `pid.hpp` required for accessing `process::UPID`
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/timer.hpp 6bf7216ab3994044faaf92c865b5324b89330106
>
> Diff: https://reviews.apache.org/r/44463/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 44463: Made `timer.hpp` header self-contained.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44463/#review122973
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On March 7, 2016, 7:38 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44463/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 7:38 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `timer.hpp` was missing an include for `pid.hpp` required for accessing `process::UPID`
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/timer.hpp 6bf7216ab3994044faaf92c865b5324b89330106
>
> Diff: https://reviews.apache.org/r/44463/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>