You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/08/29 20:43:18 UTC
Review Request 25195: Fixed MasterZooKeeperTest.LostZooKeeperCluster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25195/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
- Should have placed the FUTURE_MESSAGE that attempts to capture this
messages before the slave starts.
Diffs
-----
src/tests/master_tests.cpp 9de242432afd404fc820b3a99daca1043e43a844
Diff: https://reviews.apache.org/r/25195/diff/
Testing
-------
Ran MasterZooKeeperTest.LostZooKeeperCluster 1000 for iterations.
Thanks,
Jiang Yan Xu
Re: Review Request 25195: Fixed
MasterZooKeeperTest.LostZooKeeperCluster
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25195/#review51949
-----------------------------------------------------------
Bad patch!
Reviews applied: [25195]
Failed command: git apply --index 25195.patch
Error:
error: patch failed: src/tests/master_tests.cpp:1770
error: src/tests/master_tests.cpp: patch does not apply
- Mesos ReviewBot
On Aug. 29, 2014, 6:43 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25195/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 6:43 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Should have placed the FUTURE_MESSAGE that attempts to capture this
> messages before the slave starts.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 9de242432afd404fc820b3a99daca1043e43a844
>
> Diff: https://reviews.apache.org/r/25195/diff/
>
>
> Testing
> -------
>
> Ran MasterZooKeeperTest.LostZooKeeperCluster 1000 for iterations.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 25195: Fixed
MasterZooKeeperTest.LostZooKeeperCluster
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25195/#review51919
-----------------------------------------------------------
Ship it!
src/tests/master_tests.cpp
<https://reviews.apache.org/r/25195/#comment90610>
Add a new line above.
- Jie Yu
On Aug. 29, 2014, 6:43 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25195/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2014, 6:43 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Should have placed the FUTURE_MESSAGE that attempts to capture this
> messages before the slave starts.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 9de242432afd404fc820b3a99daca1043e43a844
>
> Diff: https://reviews.apache.org/r/25195/diff/
>
>
> Testing
> -------
>
> Ran MasterZooKeeperTest.LostZooKeeperCluster 1000 for iterations.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>