You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/25 03:54:35 UTC
[GitHub] [incubator-nuttx] btashton opened a new pull request #1640: Add a workflow_dispatch hook so that a App PR can be used
btashton opened a new pull request #1640:
URL: https://github.com/apache/incubator-nuttx/pull/1640
## Summary
With the addition of the dispatch_request we should be able to now supply a PR number for a PR in the apps repo and enable running a build against that. This does not yet let us use some kind of comment to do it, there is at least a manual way to trigger.
This is a fairly new feature to GitHub Actions, but we have already enabled it on the website repo
https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/
This should be low risk, but it is hard to test until it is merged in. If it works here I'll update the apps repo to allow supplying a os PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1640: Add a workflow_dispatch hook so that a App PR can be used
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1640:
URL: https://github.com/apache/incubator-nuttx/pull/1640#issuecomment-679568059
@xiaoxiang781216 I think this will let us at least move forward in the right direction. We should at some point still move all that logic I have about branches and refs into an action we can share and also write more clearly in nodejs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton closed pull request #1640: Add a workflow_dispatch hook so that a App PR can be used
Posted by GitBox <gi...@apache.org>.
btashton closed pull request #1640:
URL: https://github.com/apache/incubator-nuttx/pull/1640
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1640: Add a workflow_dispatch hook so that a App PR can be used
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1640:
URL: https://github.com/apache/incubator-nuttx/pull/1640#issuecomment-681208666
@xiaoxiang781216 I think its too ugly of a hack. Best to just write the action and do it correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1640: Add a workflow_dispatch hook so that a App PR can be used
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1640:
URL: https://github.com/apache/incubator-nuttx/pull/1640#issuecomment-679585468
Hmm this might be more awkward than I thought. Looks like you have to trigger it on a branch, so if we have a PR 100 in the OS and PR 200 in apps you would have to place PR 100 on a branch in OS and then select the workflow dispatch with the app pr input of 200. You cannot dispatch the workflow on PR 100 and supply the App PR of 200 as an input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org