Re: svn commit: r409942 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c

[Colm MacCarthaigh <co...@stdlib.net>]

On Sun, May 28, 2006 at 10:32:04AM -0000, rpluem@apache.org wrote:
>          rv = apr_file_rename(dobj->tempfile, dobj->datafile, r->pool);
>          if (rv != APR_SUCCESS) {
> -            /* XXX log */
> +            ap_log_error(APLOG_MARK, APLOG_DEBUG, rv, r->server,
> +                         "disk_cache: rename tempfile to datafile failed:"
> +                         " %s -> %s", dobj->tempfile, dobj->datafile);
> +            apr_file_remove(dobj->tempfile, r->pool);
>          }

A significant source of this kind of error is that the filesystem
suddenly becomes read-only. Either to a protective automative re-mount
by the kernel, a log journal becoming full, in which case the remove
will also fail :/

-- 
Colm MacCárthaigh                        Public Key: colm+pgp@stdlib.net

Re: svn commit: r409942 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_disk_cache.c

[Ruediger Pluem <rp...@apache.org>]

On 05/28/2006 02:33 PM, Colm MacCarthaigh wrote:
> On Sun, May 28, 2006 at 10:32:04AM -0000, rpluem@apache.org wrote:

> 
> A significant source of this kind of error is that the filesystem
> suddenly becomes read-only. Either to a protective automative re-mount
> by the kernel, a log journal becoming full, in which case the remove
> will also fail :/

Thats true, but

1. In this case no further temporary files get created anyway.
2. Trying to remove it does not really hurt, even if it fails.

OTH if becoming read-only is not the source of the error we clean things up.


Regards

Rüdiger