You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/12/09 16:54:43 UTC
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6394: Flink: Port Support read options in flink source to 1.14 & 1.16
stevenzwu commented on code in PR #6394:
URL: https://github.com/apache/iceberg/pull/6394#discussion_r1044643611
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java:
##########
@@ -112,8 +111,10 @@ public Builder project(TableSchema schema) {
return this;
}
- public Builder limit(long newLimit) {
- contextBuilder.limit(newLimit);
+ public Builder limit(Long newLimit) {
Review Comment:
why changing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org