[GitHub] [superset] reesercollins commented on a diff in pull request #20312: feat(api): Add option to enable sync on import

[GitBox <gi...@apache.org>]

reesercollins commented on code in PR #20312:
URL: https://github.com/apache/superset/pull/20312#discussion_r947930398


##########
superset/datasets/api.py:
##########
@@ -769,9 +775,15 @@ def import_(self) -> Response:
             else None
         )
         overwrite = request.form.get("overwrite") == "true"
+        sync_columns = request.form.get("sync_columns") == "true"
+        sync_metrics = request.form.get("sync_metrics") == "true"
 
         command = ImportDatasetsCommand(
-            contents, passwords=passwords, overwrite=overwrite
+            contents,
+            passwords=passwords,
+            overwrite=overwrite,
+            sync_columns=sync_columns,
+            sync_metrics=sync_metrics,

Review Comment:
   It appears that V1 uses the overwrite flag to denote syncing columns and metrics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org