You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/04/30 13:56:41 UTC

[GitHub] [thrift] kashirin-alex opened a new pull request, #2597: THRIFT-5576: fix old-style cast and redundant copy

kashirin-alex opened a new pull request, #2597:
URL: https://github.com/apache/thrift/pull/2597

   
   **_Generated was:_**
   ```CPP
   class FU_LB : public virtual ::apache::thrift::TBase {
    public:
   
     FU_LB(const FU_LB&);
     FU_LB(FU_LB&&) noexcept;
     FU_LB& operator=(const FU_LB&);
     FU_LB& operator=(FU_LB&&) noexcept;
     FU_LB() noexcept
           : ctrl(0),
             op((FU_LIST_OP::type)0),
             pos(0) {
       op = (FU_LIST_OP::type)0;
   
     }
   
     virtual ~FU_LB() noexcept;
    ```
    
   **_Generated became:_**
    ```CPP
   class FU_LB : public virtual ::apache::thrift::TBase {
    public:
   
     FU_LB(const FU_LB&);
     FU_LB(FU_LB&&) noexcept;
     FU_LB& operator=(const FU_LB&);
     FU_LB& operator=(FU_LB&&) noexcept;
     FU_LB() noexcept
           : ctrl(0),
             op(static_cast<FU_LIST_OP::type>(0)),
             pos(0) {
     }
   
     virtual ~FU_LB() noexcept;
    ```
    
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G merged pull request #2597: THRIFT-5576: fix old-style cast and redundant copy

Posted by GitBox <gi...@apache.org>.
Jens-G merged PR #2597:
URL: https://github.com/apache/thrift/pull/2597


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] ctubbsii commented on pull request #2597: THRIFT-5576: fix old-style cast and redundant copy

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #2597:
URL: https://github.com/apache/thrift/pull/2597#issuecomment-1133761732

   For convenience, the diff between the two above are:
   
   ```diff
   @@ -7,10 +7,8 @@
      FU_LB& operator=(FU_LB&&) noexcept;
      FU_LB() noexcept
            : ctrl(0),
   -          op((FU_LIST_OP::type)0),
   +          op(static_cast<FU_LIST_OP::type>(0)),
              pos(0) {
   -    op = (FU_LIST_OP::type)0;
   -
      }
    
      virtual ~FU_LB() noexcept;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org