You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/12/23 09:58:03 UTC
[GitHub] [flink] reswqa opened a new pull request, #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.
reswqa opened a new pull request, #21553:
URL: https://github.com/apache/flink/pull/21553
## What is the purpose of the change
*flink-table-api-java-bridge do not have suffix of scala version from 1.15, but document of hive still using the artifactId with scala as example.*
## Brief change log
- *fix incorrect dependency artifactId in hive overview.*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.
Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #21553:
URL: https://github.com/apache/flink/pull/21553#issuecomment-1385069595
@reswqa @ZhongFuCheng3y Hive requires the `flink-table-planner_2.12-<Flink-Version>.jar`, so for example ` flink-table-planner_2.12-1.16.0.jar`. See https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/connectors/table/hive/overview/#moving-the-planner-jar
That means that if you want to run this locally, you should not include `<artifactId>flink-table-api-java-bridge_2.12</artifactId>` but you should include <artifactId>flink-table-api-scala-bridge_2.12</artifactId>, per https://nightlies.apache.org/flink/flink-docs-master/docs/dev/configuration/overview/#flink-apis
That's what I tried to say by mention that Hive still requires Scala (hence it still has the Scala suffix), which implies that you will also need to use all other artifacts in the Scala version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser closed pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.
Posted by GitBox <gi...@apache.org>.
MartijnVisser closed pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.
URL: https://github.com/apache/flink/pull/21553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.
Posted by GitBox <gi...@apache.org>.
reswqa commented on PR #21553:
URL: https://github.com/apache/flink/pull/21553#issuecomment-1363804541
@MartijnVisser Would you mind review this? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21553:
URL: https://github.com/apache/flink/pull/21553#issuecomment-1363808387
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6e44af00e7b6a89711238cd82aa8e3c01ac59710",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6e44af00e7b6a89711238cd82aa8e3c01ac59710",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6e44af00e7b6a89711238cd82aa8e3c01ac59710 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.
Posted by GitBox <gi...@apache.org>.
reswqa commented on PR #21553:
URL: https://github.com/apache/flink/pull/21553#issuecomment-1367810973
@MartijnVisser If I haven't misunderstood your meaning, you mean that the scala version is still needed as a suffix for the hi connector dependency, but I only modified the artifactId of the flink-table-api-java-bridge in the document.
This module dose not need the suffix of scala version, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ZhongFuCheng3y commented on pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.
Posted by GitBox <gi...@apache.org>.
ZhongFuCheng3y commented on PR #21553:
URL: https://github.com/apache/flink/pull/21553#issuecomment-1398010881
> @reswqa @ZhongFuCheng3y Hive requires the `flink-table-planner_2.12-<Flink-Version>.jar`, so for example ` flink-table-planner_2.12-1.16.0.jar`. See https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/connectors/table/hive/overview/#moving-the-planner-jar
>
> That means that if you want to run this locally, you should not include `<artifactId>flink-table-api-java-bridge_2.12</artifactId>` but you should include flink-table-api-scala-bridge_2.12, per https://nightlies.apache.org/flink/flink-docs-master/docs/dev/configuration/overview/#flink-apis
>
> That's what I tried to say by mention that Hive still requires Scala (hence it still has the Scala suffix), which implies that you will also need to use all other artifacts in the Scala version.
ths!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] ZhongFuCheng3y commented on pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.
Posted by GitBox <gi...@apache.org>.
ZhongFuCheng3y commented on PR #21553:
URL: https://github.com/apache/flink/pull/21553#issuecomment-1384739148
> @MartijnVisser If I haven't misunderstood your meaning, you mean that the scala version is still needed as a suffix for the `flink-connector-hive_${scala.binary.version}` dependency, but I only modified the artifactId of the `flink-table-api-java-bridge` in the document.  This module dose not need this suffix of scala version, and after flink 1.15.0, we can not download `flink-table-api-java-bridge_2.12` from maven repo, right?
i have same question , how do you solove it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] reswqa commented on pull request #21553: [FLINK-30492][doc] fix incorrect dependency artifactId in hive overview.
Posted by GitBox <gi...@apache.org>.
reswqa commented on PR #21553:
URL: https://github.com/apache/flink/pull/21553#issuecomment-1384778651
@ZhongFuCheng3y In fact, the pull request has been closed because @MartijnVisser doesn't think it needs to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org