[GitHub] [zeppelin] Reamer commented on a diff in pull request #4519: [ZEPPELIN-5855] Refactor docker plugin and remove powermock

["Reamer (via GitHub)" <gi...@apache.org>]

Reamer commented on code in PR #4519:
URL: https://github.com/apache/zeppelin/pull/4519#discussion_r1087924889


##########
zeppelin-plugins/launcher/docker/src/main/java/org/apache/zeppelin/interpreter/launcher/DockerInterpreterProcess.java:
##########
@@ -242,18 +233,22 @@ public void progress(ProgressMessage message) throws DockerException {
       throw new IOException(e.getMessage());
     } catch (InterruptedException e) {
       LOGGER.error(e.getMessage(), e);
+      // Restore interrupted state...
+      Thread.currentThread().interrupt();
       throw new IOException(e.getMessage());
     }
 
     long startTime = System.currentTimeMillis();
 
     // wait until interpreter send dockerStarted message through thrift rpc
     synchronized (dockerStarted) {
-      if (!dockerStarted.get()) {
+      while (!dockerStarted.get()) {

Review Comment:
   Your right, I will change this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org