You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/09/24 12:53:38 UTC
[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz opened a new pull request #5: SLING-9766 - take selectors into account in cache key
bdelacretaz opened a new pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/5
As per https://issues.apache.org/jira/browse/SLING-9766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz closed pull request #5: SLING-9766 - take selectors into account in cache key
Posted by GitBox <gi...@apache.org>.
bdelacretaz closed pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #5: SLING-9766 - take selectors into account in cache key
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/5#issuecomment-698326457
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #5: SLING-9766 - take selectors into account in cache key
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/5#issuecomment-698326457
...ah, wait, my patch breaks some other tests...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz commented on pull request #5: SLING-9766 - take selectors into account in cache key
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/5#issuecomment-698340524
Invalid, sorry for the noise...our own cache only stores queries so it is correct to omit selectors in the cache key. They will be taken into account by the HTTP front-end when caching, as they are part of the URL.
I'll commit just the test that validates the current behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-graphql-core] bdelacretaz closed pull request #5: SLING-9766 - take selectors into account in cache key
Posted by GitBox <gi...@apache.org>.
bdelacretaz closed pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-graphql-core/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org