You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Mona Chitnis (JIRA)" <ji...@apache.org> on 2012/05/03 00:44:50 UTC
[jira] [Created] (OOZIE-828) XLogStreamer has missing i/o stream
close statements
Mona Chitnis created OOZIE-828:
----------------------------------
Summary: XLogStreamer has missing i/o stream close statements
Key: OOZIE-828
URL: https://issues.apache.org/jira/browse/OOZIE-828
Project: Oozie
Issue Type: Bug
Affects Versions: 3.2.0
Reporter: Mona Chitnis
Assignee: Mona Chitnis
Fix For: 3.2.0
XLogStreamer streamLog() function has missing i/o stream close statements at a couple of places. This might hamper accurate i/o of log stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-828) XLogStreamer has missing i/o stream
close statements
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267014#comment-13267014 ]
jiraposter@reviews.apache.org commented on OOZIE-828:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4975/#review7489
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/4975/#comment16587>
This is not required as Xlogreader will close the underlying stream (In this case, gzipInputStrem())
trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java
<https://reviews.apache.org/r/4975/#comment16584>
logreader.close() will call ifs.close()..no need for both
- Virag
On 2012-05-02 23:02:50, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4975/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 23:02:50)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Refer to https://issues.apache.org/jira/browse/OOZIE-828
bq.
bq.
bq. This addresses bug OOZIE-828.
bq. https://issues.apache.org/jira/browse/OOZIE-828
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1326832
bq.
bq. Diff: https://reviews.apache.org/r/4975/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. some end-to-end tests experiencing interruption in getting log stream from multiple gz files
bq. oozie job -log <id>
bq.
bq. Testing with patch to see if this is the cause. In either case, these close statements are required.
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> XLogStreamer has missing i/o stream close statements
> ----------------------------------------------------
>
> Key: OOZIE-828
> URL: https://issues.apache.org/jira/browse/OOZIE-828
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Labels: oozie
> Fix For: 3.2.0
>
>
> XLogStreamer streamLog() function has missing i/o stream close statements at a couple of places. This might hamper accurate i/o of log stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-828) XLogStreamer has missing i/o stream
close statements
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278333#comment-13278333 ]
jiraposter@reviews.apache.org commented on OOZIE-828:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4975/#review7965
-----------------------------------------------------------
Agree with review comments that closing logReader in both cases will, in turn, close the inputstream it uses. Closing as invalid
- Mona
On 2012-05-02 23:02:50, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4975/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-02 23:02:50)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Refer to https://issues.apache.org/jira/browse/OOZIE-828
bq.
bq.
bq. This addresses bug OOZIE-828.
bq. https://issues.apache.org/jira/browse/OOZIE-828
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1326832
bq.
bq. Diff: https://reviews.apache.org/r/4975/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. some end-to-end tests experiencing interruption in getting log stream from multiple gz files
bq. oozie job -log <id>
bq.
bq. Testing with patch to see if this is the cause. In either case, these close statements are required.
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> XLogStreamer has missing i/o stream close statements
> ----------------------------------------------------
>
> Key: OOZIE-828
> URL: https://issues.apache.org/jira/browse/OOZIE-828
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Labels: oozie
> Fix For: 3.2.0
>
>
> XLogStreamer streamLog() function has missing i/o stream close statements at a couple of places. This might hamper accurate i/o of log stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-828) XLogStreamer has missing i/o stream
close statements
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mona Chitnis updated OOZIE-828:
-------------------------------
For the patch committed in trunk with this JIRA ID (also available under the same JIRA ID in Apache ReviewBoard system), I grant license to ASF for inclusion in ASF works (as per the Apache License §5)
> XLogStreamer has missing i/o stream close statements
> ----------------------------------------------------
>
> Key: OOZIE-828
> URL: https://issues.apache.org/jira/browse/OOZIE-828
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Labels: oozie
> Fix For: 3.2.0
>
>
> XLogStreamer streamLog() function has missing i/o stream close statements at a couple of places. This might hamper accurate i/o of log stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OOZIE-828) XLogStreamer has missing i/o stream
close statements
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mona Chitnis resolved OOZIE-828.
--------------------------------
Resolution: Invalid
> XLogStreamer has missing i/o stream close statements
> ----------------------------------------------------
>
> Key: OOZIE-828
> URL: https://issues.apache.org/jira/browse/OOZIE-828
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Labels: oozie
> Fix For: 3.2.0
>
>
> XLogStreamer streamLog() function has missing i/o stream close statements at a couple of places. This might hamper accurate i/o of log stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-828) XLogStreamer has missing i/o stream
close statements
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266995#comment-13266995 ]
jiraposter@reviews.apache.org commented on OOZIE-828:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4975/
-----------------------------------------------------------
Review request for oozie.
Summary
-------
Refer to https://issues.apache.org/jira/browse/OOZIE-828
This addresses bug OOZIE-828.
https://issues.apache.org/jira/browse/OOZIE-828
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1326832
Diff: https://reviews.apache.org/r/4975/diff
Testing
-------
some end-to-end tests experiencing interruption in getting log stream from multiple gz files
oozie job -log <id>
Testing with patch to see if this is the cause. In either case, these close statements are required.
Thanks,
Mona
> XLogStreamer has missing i/o stream close statements
> ----------------------------------------------------
>
> Key: OOZIE-828
> URL: https://issues.apache.org/jira/browse/OOZIE-828
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Mona Chitnis
> Assignee: Mona Chitnis
> Labels: oozie
> Fix For: 3.2.0
>
>
> XLogStreamer streamLog() function has missing i/o stream close statements at a couple of places. This might hamper accurate i/o of log stream.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira