You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Tung TRAN (Jira)" <se...@james.apache.org> on 2023/06/23 07:14:00 UTC

[jira] [Created] (JAMES-3917) Jenkin CI Build should be strict about Scala imports ordering in the code

Tung TRAN created JAMES-3917:
--------------------------------

             Summary: Jenkin CI Build should be strict about Scala imports ordering in the code
                 Key: JAMES-3917
                 URL: https://issues.apache.org/jira/browse/JAMES-3917
             Project: James Server
          Issue Type: New Feature
            Reporter: Tung TRAN


For now, we do not have strict rules with Scala regarding import orders. Not everybody has the same layout and it potentially reduces readability in PRs on code change if somebody got a different import layout than the initial code.

We should be more strict on import ordering like we do with Java.

Proposed layout:
{code:java}
base package imports
___blank line___
java
___blank line___
all other imports
___blank line___
scala{code}

Should modify the scalafix maven plugin to do a strict check on import and fail the build if that last one isn't respected.  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org