You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2008/12/27 22:00:46 UTC
[jira] Created: (SOLR-939) ValueSourceRangeFilter/Query
ValueSourceRangeFilter/Query
----------------------------
Key: SOLR-939
URL: https://issues.apache.org/jira/browse/SOLR-939
Project: Solr
Issue Type: New Feature
Reporter: Yonik Seeley
Assignee: Yonik Seeley
Fix For: 1.4
Ability to do a range query based on a FieldCache entry or a FunctionQuery (ValueSource).
Equivalent to Lucene's FieldCacheRangeQuery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-939) ValueSourceRangeFilter/Query
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-939:
------------------------------
Attachment: SOLR-939.patch
Attaching patch with some more progress... fixed some bugs and created some query tests (currently failing).
> ValueSourceRangeFilter/Query
> ----------------------------
>
> Key: SOLR-939
> URL: https://issues.apache.org/jira/browse/SOLR-939
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-939.patch, SOLR-939.patch, SOLR-939.patch
>
>
> Ability to do a range query based on a FieldCache entry or a FunctionQuery (ValueSource).
> Equivalent to Lucene's FieldCacheRangeQuery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-939) ValueSourceRangeFilter/Query
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-939:
------------------------------
Attachment: SOLR-939.patch
OK, I think I've fixed all the issues!
> ValueSourceRangeFilter/Query
> ----------------------------
>
> Key: SOLR-939
> URL: https://issues.apache.org/jira/browse/SOLR-939
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-939.patch, SOLR-939.patch, SOLR-939.patch, SOLR-939.patch
>
>
> Ability to do a range query based on a FieldCache entry or a FunctionQuery (ValueSource).
> Equivalent to Lucene's FieldCacheRangeQuery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-939) ValueSourceRangeFilter/Query
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley resolved SOLR-939.
-------------------------------
Resolution: Fixed
Committed.
> ValueSourceRangeFilter/Query
> ----------------------------
>
> Key: SOLR-939
> URL: https://issues.apache.org/jira/browse/SOLR-939
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-939.patch, SOLR-939.patch, SOLR-939.patch, SOLR-939.patch
>
>
> Ability to do a range query based on a FieldCache entry or a FunctionQuery (ValueSource).
> Equivalent to Lucene's FieldCacheRangeQuery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-939) ValueSourceRangeFilter/Query
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-939:
------------------------------
Attachment: SOLR-939.patch
Attaching incomplete draft to help give a feel for the approach.
Functionallity can be accessed via frange QParser (stands for function range).
fq={!frange l=5 u=10}popularity
fq={!frange l=5 u=10}product(popularity,2)
> ValueSourceRangeFilter/Query
> ----------------------------
>
> Key: SOLR-939
> URL: https://issues.apache.org/jira/browse/SOLR-939
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-939.patch
>
>
> Ability to do a range query based on a FieldCache entry or a FunctionQuery (ValueSource).
> Equivalent to Lucene's FieldCacheRangeQuery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-939) ValueSourceRangeFilter/Query
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679236#action_12679236 ]
Yonik Seeley commented on SOLR-939:
-----------------------------------
Right - it made sense to me to go through the FunctionQuery/ValueSource abstraction to do range filters, as it's a superset of just going off of the FieldCache (it could work with functions, FileFloatSource, and future payload or column-stored fields too).
I've been meaning to get back to this patch... at a minimum it would need support for all of the field types as well as tests. I think I may even have some local updates since this last patch - I'll have to check.
It would be nice if one could tag a field with info to use ValueSourceRangeFilter for any range queries... but it doesn't seem necessary before committing this underlying functionality.
> ValueSourceRangeFilter/Query
> ----------------------------
>
> Key: SOLR-939
> URL: https://issues.apache.org/jira/browse/SOLR-939
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-939.patch
>
>
> Ability to do a range query based on a FieldCache entry or a FunctionQuery (ValueSource).
> Equivalent to Lucene's FieldCacheRangeQuery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-939) ValueSourceRangeFilter/Query
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12721839#action_12721839 ]
David Smiley commented on SOLR-939:
-----------------------------------
I just happened to be looking at the code for this in StrField.java and I observed that the package-class StrFieldSource isn't being used.
> ValueSourceRangeFilter/Query
> ----------------------------
>
> Key: SOLR-939
> URL: https://issues.apache.org/jira/browse/SOLR-939
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-939.patch, SOLR-939.patch, SOLR-939.patch, SOLR-939.patch
>
>
> Ability to do a range query based on a FieldCache entry or a FunctionQuery (ValueSource).
> Equivalent to Lucene's FieldCacheRangeQuery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-939) ValueSourceRangeFilter/Query
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679282#action_12679282 ]
Shalin Shekhar Mangar commented on SOLR-939:
--------------------------------------------
bq. Right - it made sense to me to go through the FunctionQuery/ValueSource abstraction to do range filters, as it's a superset of just going off of the FieldCache (it could work with functions, FileFloatSource, and future payload or column-stored fields too).
Very cool!
bq. It would be nice if one could tag a field with info to use ValueSourceRangeFilter for any range queries
As an extra attribute in the schema? e.g.
{code:xml}
<field name="xyz" type="integer" indexed="true" stored="true" useValueSourceRangeFilter="true" />
{code}
+1 for this. It is easier/cleaner than the local param syntax but I guess we'd need to support both anyway. Solrj does not have API methods to manipulate local params and I think this is a good time to add that support.
bq. I've been meaning to get back to this patch... at a minimum it would need support for all of the field types as well as tests. I think I may even have some local updates since this last patch - I'll have to check.
Can you post your updates? SOLR-940 (Trie support) is mostly done and I can try to spend some time on this one. Per the 1.4 release discussion, these two are the major features stopping the 1.4 release, though I'm sure we'll find more :)
> ValueSourceRangeFilter/Query
> ----------------------------
>
> Key: SOLR-939
> URL: https://issues.apache.org/jira/browse/SOLR-939
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-939.patch
>
>
> Ability to do a range query based on a FieldCache entry or a FunctionQuery (ValueSource).
> Equivalent to Lucene's FieldCacheRangeQuery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-939) ValueSourceRangeFilter/Query
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679062#action_12679062 ]
Shalin Shekhar Mangar commented on SOLR-939:
--------------------------------------------
Yonik, if I understand this correctly (and I don't understand much), the difference between plain FieldCacheRangeFilter and ValueSourceRangeFilter is that VSRF can be used with fields as well as function queries, right?
To complete this patch, we would need modifications to other field types as well (just as the patch does for IntField). Are there other changes required before this can be committed?
> ValueSourceRangeFilter/Query
> ----------------------------
>
> Key: SOLR-939
> URL: https://issues.apache.org/jira/browse/SOLR-939
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-939.patch
>
>
> Ability to do a range query based on a FieldCache entry or a FunctionQuery (ValueSource).
> Equivalent to Lucene's FieldCacheRangeQuery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-939) ValueSourceRangeFilter/Query
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yonik Seeley updated SOLR-939:
------------------------------
Attachment: SOLR-939.patch
Here's the latest I had... I don't recall exactly what the state of things were, but I had started working on tests (TestRangeQuery) and it built an index will a bunch of different field types, but there wasn't yet code to query.
> ValueSourceRangeFilter/Query
> ----------------------------
>
> Key: SOLR-939
> URL: https://issues.apache.org/jira/browse/SOLR-939
> Project: Solr
> Issue Type: New Feature
> Reporter: Yonik Seeley
> Assignee: Yonik Seeley
> Fix For: 1.4
>
> Attachments: SOLR-939.patch, SOLR-939.patch
>
>
> Ability to do a range query based on a FieldCache entry or a FunctionQuery (ValueSource).
> Equivalent to Lucene's FieldCacheRangeQuery
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.