You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2022/07/12 02:36:31 UTC

[GitHub] [tika] lfcnassif opened a new pull request, #605: TIKA-3815: set GMT timezone for unspecified timezones like drew noakes,

lfcnassif opened a new pull request, #605:
URL: https://github.com/apache/tika/pull/605

   Fixes TIKA-3815.
   
   Actually Drew Noakes metadata-extractor library uses **GMT** timezone when timezone is not specified since version 2.8.1, not JVM default:
   [fix tests to work on different timezones](https://github.com/drewnoakes/metadata-extractor/commit/1899deac8af55934363183dae605e286bc79afa3)
   
   So I changed the code to reflect that and updated tests. Now `user.timezone` doesn't need to be fixed to UTC anymore to run tests, they should work on any timezone.
   
   I would like some other committer to test this to be sure tests work on a timezone different than mine (GMT-3)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tika] lfcnassif commented on pull request #605: TIKA-3815: set GMT timezone for unspecified timezones like drew noakes,

Posted by GitBox <gi...@apache.org>.
lfcnassif commented on PR #605:
URL: https://github.com/apache/tika/pull/605#issuecomment-1181936424

   I did a few more tests and I think this is fine, I'm going to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tika] lfcnassif commented on pull request #605: TIKA-3815: set GMT timezone for unspecified timezones like drew noakes,

Posted by GitBox <gi...@apache.org>.
lfcnassif commented on PR #605:
URL: https://github.com/apache/tika/pull/605#issuecomment-1181250211

   Should this be also applied to 1.x branch or we are just fixing security issues?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tika] lfcnassif merged pull request #605: TIKA-3815: set GMT timezone for unspecified timezones like drew noakes,

Posted by GitBox <gi...@apache.org>.
lfcnassif merged PR #605:
URL: https://github.com/apache/tika/pull/605


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org