You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jacob Janco <jj...@gmail.com> on 2016/04/20 22:29:02 UTC

Review Request 46416: remove hardcoding for MethodNotAllowed for http

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46416/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4126
    https://issues.apache.org/jira/browse/MESOS-4126


Repository: mesos


Description
-------

remove hardcoding for MethodNotAllowed for http


Diffs
-----

  src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 
  src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c 

Diff: https://reviews.apache.org/r/46416/diff/


Testing
-------


Thanks,

Jacob Janco


Re: Review Request 46416: remove hardcoding for MethodNotAllowed for http

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46416/#review129831
-----------------------------------------------------------



Bad patch!

Reviews applied: [46416, 46415]

Failed command: ./support/apply-review.sh -n -r 46415

Error:
2016-04-20 22:25:21 URL:https://reviews.apache.org/r/46415/diff/raw/ [2095/2095] -> "46415.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must start with a capital letter.

Full log: https://builds.apache.org/job/mesos-reviewbot/12635/console

- Mesos ReviewBot


On April 20, 2016, 8:29 p.m., Jacob Janco wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46416/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 8:29 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4126
>     https://issues.apache.org/jira/browse/MESOS-4126
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> remove hardcoding for MethodNotAllowed for http
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 
>   src/slave/http.cpp 3908e33ed5b233387790276f6f5d884452087d2c 
> 
> Diff: https://reviews.apache.org/r/46416/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>