You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2017/03/16 18:05:41 UTC
[jira] [Commented] (HBASE-16432) Revisit the asynchronous ipc
implementation
[ https://issues.apache.org/jira/browse/HBASE-16432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928548#comment-15928548 ]
Hudson commented on HBASE-16432:
--------------------------------
FAILURE: Integrated in Jenkins build HBase-1.4 #672 (See [https://builds.apache.org/job/HBase-1.4/672/])
HBASE-16584 Backport the new ipc implementation in HBASE-16432 to (zhangduo: rev 094e9a311bec55d0c198bb483b4b1d994c9428e4)
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerWithReadReplicas.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtobufRpcServiceImpl.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestSecureIPC.java
* (add) hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestCellBlockBuilder.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClient.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcClientConfigHelper.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcHandlerException.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/FlushRegionCallable.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RegionReplicaReplicationEndpoint.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcControllerFactory.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClient.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslWrapHandler.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/protobuf/generated/TestRpcServiceProtos.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUnwrapHandler.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableLocator.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java
* (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestAsyncIPC.java
* (add) hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestHBaseRpcControllerImpl.java
* (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CellScannerButNoCodecException.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcController.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/IPCUtil.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcClientLeaks.java
* (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslClientHandler.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DelegatingHBaseRpcController.java
* (edit) hbase-server/src/test/protobuf/test_rpc_service.proto
* (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DelegatingPayloadCarryingRpcController.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcConnection.java
* (edit) pom.xml
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcControllerImpl.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClient.java
* (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestIPCUtil.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/Call.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslChallengeDecoder.java
* (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcClient.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHCM.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcClient.java
* (delete) hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestPayloadCarryingRpcController.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/FallbackDisallowedException.java
* (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/TimeLimitedRpcController.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CallCancelledException.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestBlockingIPC.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/protobuf/generated/TestProtos.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestHBaseAdminNoCluster.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessorNoCluster.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/ProtobufCoprocessorService.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestDelegationTokenWithEncryption.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/security/AbstractHBaseSaslRpcClient.java
* (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestGlobalEventLoopGroup.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BufferCallBeforeInitHandler.java
* (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientImpl.java
* (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
* (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/security/AbstractTestSecureIPC.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DefaultNettyEventLoopConfig.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/MasterCoprocessorRpcChannel.java
* (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncRpcChannel.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ReplicationProtbufUtil.java
* (edit) hbase-server/src/test/protobuf/test.proto
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/AbstractTestIPC.java
* (add) hbase-client/src/test/java/org/apache/hadoop/hbase/security/TestHBaseSaslRpcClient.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RegionCoprocessorRpcChannel.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java
* (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/ipc/IntegrationTestRpcClient.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestGenerateDelegationToken.java
* (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncServerResponseHandler.java
* (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AsyncCall.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* (add) hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyIPC.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CellBlockBuilder.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/MetaTableLocator.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientFactory.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlClient.java
* (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromAdmin.java
* (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALEditsReplaySink.java
* (delete) hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestAsyncSecureIPC.java
* (delete) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/PayloadCarryingRpcController.java
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRpcControllerFactory.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/CallEvent.java
* (add) hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java
* (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java
> Revisit the asynchronous ipc implementation
> -------------------------------------------
>
> Key: HBASE-16432
> URL: https://issues.apache.org/jira/browse/HBASE-16432
> Project: HBase
> Issue Type: Umbrella
> Components: rpc
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
>
> Seems the current approach of implementing AsyncTable is in trouble as we expose some netty classes in our public interfaces.
> I agree that we should not do this. The AsyncTable should be implemented using the asynchronous protobuf stub, and we could use CompletableFuture or Deferred instead of netty's Future. I think the problem of netty's future is that it is tighten with netty's executor. This makes it impossible to use without netty.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)