You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by PurelyApplied <gi...@git.apache.org> on 2017/05/22 17:42:08 UTC

[GitHub] geode issue #522: GEODE-2953: Imports optimized in every file with a wildcar...

Github user PurelyApplied commented on the issue:

    https://github.com/apache/geode/pull/522
  
    Please review the diff, or run a regex search matching `import .*\*;\n`.  This regex hits 1024 occurrences in production and 2205 occurrences in test code.
    
    Some of these occurrences are commented out.  Matching `^import .*\*;\n` hits 827 production and 2175 test occurrences.
    
    1388 classes going against best practices is indeed alarming, but I do not believe it is incorrect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---