You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/13 20:33:50 UTC
[GitHub] [incubator-superset] codecov-io commented on pull request #12026: feat: load examples from config instead of code
codecov-io commented on pull request #12026:
URL: https://github.com/apache/incubator-superset/pull/12026#issuecomment-744064475
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12026?src=pr&el=h1) Report
> Merging [#12026](https://codecov.io/gh/apache/incubator-superset/pull/12026?src=pr&el=desc) (f886f32) into [master](https://codecov.io/gh/apache/incubator-superset/commit/022d7556401750c6bc28a081a6780fce2f4033fd?el=desc) (022d755) will **decrease** coverage by `2.73%`.
> The diff coverage is `44.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12026?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12026 +/- ##
==========================================
- Coverage 66.66% 63.93% -2.74%
==========================================
Files 951 472 -479
Lines 46663 29058 -17605
Branches 4571 0 -4571
==========================================
- Hits 31106 18577 -12529
+ Misses 15421 10481 -4940
+ Partials 136 0 -136
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.93% <44.44%> (-0.67%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12026?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/12026/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `40.66% <0.00%> (+0.13%)` | :arrow_up: |
| [superset/examples/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12026/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvdXRpbHMucHk=) | `31.57% <31.57%> (ø)` | |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12026/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `57.14% <39.28%> (-35.72%)` | :arrow_down: |
| [superset/commands/importers/v1/examples.py](https://codecov.io/gh/apache/incubator-superset/pull/12026/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL2V4YW1wbGVzLnB5) | `44.23% <44.23%> (ø)` | |
| [superset/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12026/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL19faW5pdF9fLnB5) | `95.94% <100.00%> (ø)` | |
| [superset/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12026/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | `86.11% <100.00%> (ø)` | |
| [...erset/dashboards/commands/importers/v1/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12026/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/12026/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `93.75% <100.00%> (+2.08%)` | :arrow_up: |
| [superset/datasets/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/12026/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvc2NoZW1hcy5weQ==) | `96.46% <100.00%> (+0.03%)` | :arrow_up: |
| [superset/examples/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/12026/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [504 more](https://codecov.io/gh/apache/incubator-superset/pull/12026/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12026?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12026?src=pr&el=footer). Last update [022d755...f886f32](https://codecov.io/gh/apache/incubator-superset/pull/12026?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org