You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "waterWang (via GitHub)" <gi...@apache.org> on 2026/08/09 01:08:40 UTC

[PR] [Dameng][TypeConverter] Add NCHAR data type support to DmdbTypeConverter [seatunnel]

waterWang opened a new pull request, #11716:
URL: https://github.com/apache/seatunnel/pull/11716

   ### Purpose
   
   Add NCHAR data type support to DmdbTypeConverter, which is currently missing.
   
   ### Changes
   
   - Add `DM_NCHAR` constant
   - Add `case DM_NCHAR:` to the `convert()` method, treated the same as NVARCHAR (STRING type with charTo4ByteLength)
   
   ### Related Issues
   
   - Fixes #11688


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dameng][TypeConverter] Add NCHAR data type support to DmdbTypeConverter [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11716:
URL: https://github.com/apache/seatunnel/pull/11716#issuecomment-5229135854

   Good job.
   
   Thanks a lot for your valuable contribution to Apache SeaTunnel!
   
   To pass the automated CI checks for this PR, could you please enable CI workflows in your forked repository first? You can refer to the check run link below as a reference for the required CI configuration  https://github.com/apache/seatunnel/pull/11716/checks?check_run_id=93179350641
   
   If you run into any trouble enabling CI or encounter related errors during the process, feel free to leave a comment here. Contributors are always ready to offer help~
   
   <img width="2412" height="1472" alt="image" src="https://github.com/user-attachments/assets/6abd2ea1-da45-4d78-a81c-0158f2d7a851" />


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dameng][TypeConverter] Add NCHAR data type support to DmdbTypeConverter [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #11716:
URL: https://github.com/apache/seatunnel/pull/11716#issuecomment-5233642224

   Thanks for your contribution! This is a solid addition to the project, and your attention to detail really shows. Contributors like you are what keep this community moving forward. Feel free to keep the PRs coming — we're always glad to have you here!
   
   Please ignore the following message if you have joined in the Slack~
   ```
   To facilitate focused communication among contributors, we’ve created a brand-new dedicated #contributors channel in official Slack workspace.
   Slack workspace link: https://s.apache.org/seatunnel-slack
   
   This channel is designed for technical discussions, feature design brainstorming, roadmap sync and direct communication with project core Contributors. Everyone who contributes code, docs, test cases or community ideas is warmly invited to join, share thoughts and collaborate together under The Apache Way. Welcome to join 😄
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dameng][TypeConverter] Add NCHAR data type support to DmdbTypeConverter [seatunnel]

Posted by "nzw921rx (via GitHub)" <gi...@apache.org>.
nzw921rx commented on PR #11716:
URL: https://github.com/apache/seatunnel/pull/11716#issuecomment-5661782694

   PR https://github.com/apache/seatunnel/pull/11693 merged, Thank you for your efforts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Dameng][TypeConverter] Add NCHAR data type support to DmdbTypeConverter [seatunnel]

Posted by "nzw921rx (via GitHub)" <gi...@apache.org>.
nzw921rx closed pull request #11716: [Dameng][TypeConverter] Add NCHAR data type support to DmdbTypeConverter
URL: https://github.com/apache/seatunnel/pull/11716


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org