You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2019/03/31 20:33:44 UTC

[Impala-ASF-CR] Ensure ssh config change is on its own line

Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12900


Change subject: Ensure ssh config change is on its own line
......................................................................

Ensure ssh config change is on its own line

If ~/.ssh/config does not end in a newline character, than the change
in bootstrap_system.sh would get appended to the last line, causeing
parsing of that line to fail.

Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
---
M bin/bootstrap_system.sh
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>

[Impala-ASF-CR] Ensure ssh config change is on its own line

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12900 )

Change subject: Ensure ssh config change is on its own line
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:

http://gerrit.cloudera.org:8080/#/c/12900/3/bin/bootstrap_system.sh@303
PS3, Line 303: cat ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys && chmod 0600 ~/.ssh/authorized_keys
Is this file affected by the same issue?



-- 
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Apr 2019 17:12:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Give each config change in bootstrap system.sh its own line

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Hello Lars Volker, Joe McDonnell, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12900

to look at the new patch set (#4).

Change subject: Give each config change in bootstrap_system.sh its own line
......................................................................

Give each config change in bootstrap_system.sh its own line

If a config file like ~/.ssh/config does not end in a newline
character, than the change to that file in bootstrap_system.sh would
get appended to the last line, causeing parsing of that line to fail.

Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
---
M bin/bootstrap_system.sh
1 file changed, 8 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/12900/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d3ae6c0b816113b7bf690adff4f1cd905388776
Gerrit-Change-Number: 12900
Gerrit-PatchSet: 4
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>