You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/03/11 22:12:19 UTC
[GitHub] [nifi] taftster opened a new pull request #4137: NIFI-6742 Use
JUnit TemporaryFolder when creating test databases
taftster opened a new pull request #4137: NIFI-6742 Use JUnit TemporaryFolder when creating test databases
URL: https://github.com/apache/nifi/pull/4137
- Add @Rule for TemporaryFolder
- Replace use of previous target/db with TemporaryFolder/db
- Remove use of ~/test db (in home directory)
- Remove System.out lines
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] taftster commented on issue #4137: NIFI-6742 Use JUnit
TemporaryFolder when creating test databases
Posted by GitBox <gi...@apache.org>.
taftster commented on issue #4137: NIFI-6742 Use JUnit TemporaryFolder when creating test databases
URL: https://github.com/apache/nifi/pull/4137#issuecomment-598419370
@phrocker Yes, please merge when you can.
The CI failure is unrelated - looks to be failing on a Lucene timing/race condition. Specifically:
```
[ERROR] Failures:
[ERROR] TestLuceneEventIndex.testUnauthorizedEventsGetPlaceholdersForExpandChildren:242 expected:<5> but was:<8>
```
I think this is in the category of those somewhat unreliable tests that depend on timing execution?
By the way, is there a button to re-run all the CI tests? I don't see it, but might be missing something obvious.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] asfgit closed pull request #4137: NIFI-6742 Use JUnit
TemporaryFolder when creating test databases
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4137: NIFI-6742 Use JUnit TemporaryFolder when creating test databases
URL: https://github.com/apache/nifi/pull/4137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] phrocker commented on issue #4137: NIFI-6742 Use JUnit
TemporaryFolder when creating test databases
Posted by GitBox <gi...@apache.org>.
phrocker commented on issue #4137: NIFI-6742 Use JUnit TemporaryFolder when creating test databases
URL: https://github.com/apache/nifi/pull/4137#issuecomment-598494735
@taftster sorry for the delay. I saw the message an hour ago and did a sanity build. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] joewitt commented on issue #4137: NIFI-6742 Use JUnit
TemporaryFolder when creating test databases
Posted by GitBox <gi...@apache.org>.
joewitt commented on issue #4137: NIFI-6742 Use JUnit TemporaryFolder when creating test databases
URL: https://github.com/apache/nifi/pull/4137#issuecomment-598421842
Your build stuff is fine. That test was recently ignored because it is flaky. If you rebased and pushed it would be fine. In any case this can be merged as-is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services