You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by "fishy (via GitHub)" <gi...@apache.org> on 2023/06/14 22:51:06 UTC

[GitHub] [thrift] fishy commented on pull request #2816: THRIFT-5715: Python flag to generate mutable exceptions

fishy commented on PR #2816:
URL: https://github.com/apache/thrift/pull/2816#issuecomment-1592093389

   > appvayor is currently failing, but it's also failing on all other PRs. Is this expected?
   
   kind of.
   
   but I think a better fix is to limit the scope of immutability of exceptions. we only need to limit the fields used by `__hash__` and `__eq__` to be immutable, and allow mutations of all other fields.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org