You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Archana kumari <ar...@gmail.com> on 2014/03/17 17:09:13 UTC
Review Request 19299: TRy cleanup in Mesos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Try cleanup in Mesos
Diffs
-----
src/master/detector.cpp 3a8aaed
Diff: https://reviews.apache.org/r/19299/diff/
Testing
-------
Thanks,
Archana kumari
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/#review37395
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19299]
All tests passed.
- Mesos ReviewBot
On March 17, 2014, 4:09 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 4:09 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Try cleanup in Mesos
>
>
> Diffs
> -----
>
> src/master/detector.cpp 3a8aaed
>
> Diff: https://reviews.apache.org/r/19299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/#review37396
-----------------------------------------------------------
src/master/detector.cpp
<https://reviews.apache.org/r/19299/#comment68907>
Wrap the line if it exceeds 80 chars.
- Jie Yu
On March 17, 2014, 4:09 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 4:09 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Try cleanup in Mesos
>
>
> Diffs
> -----
>
> src/master/detector.cpp 3a8aaed
>
> Diff: https://reviews.apache.org/r/19299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/#review37405
-----------------------------------------------------------
src/master/detector.cpp
<https://reviews.apache.org/r/19299/#comment68917>
This won't compile, right?
This should:
Error("some str"
"some more str");
- Jiang Yan Xu
On March 17, 2014, 10:12 a.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 10:12 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Try cleanup in Mesos
>
>
> Diffs
> -----
>
> src/master/detector.cpp 3a8aaed
>
> Diff: https://reviews.apache.org/r/19299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Jie Yu <yu...@gmail.com>.
Your patch has been committed. Please mark the review as submitted! Thank
you for the contribution!
- Jie
On Mon, Mar 17, 2014 at 1:44 PM, Jie Yu <yu...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/#review37467
> -----------------------------------------------------------
>
> Ship it!
>
>
> Ship It!
>
> - Jie Yu
>
>
> On March 17, 2014, 8:21 p.m., Archana kumari wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/19299/
> > -----------------------------------------------------------
> >
> > (Updated March 17, 2014, 8:21 p.m.)
> >
> >
> > Review request for mesos and Jie Yu.
> >
> >
> > Repository: mesos-git
> >
> >
> > Description
> > -------
> >
> > Try cleanup in Mesos
> >
> >
> > Diffs
> > -----
> >
> > src/master/detector.cpp 3a8aaed
> >
> > Diff: https://reviews.apache.org/r/19299/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Archana kumari
> >
> >
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/#review37467
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 17, 2014, 8:21 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 8:21 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Try cleanup in Mesos
>
>
> Diffs
> -----
>
> src/master/detector.cpp 3a8aaed
>
> Diff: https://reviews.apache.org/r/19299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Archana kumari <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/
-----------------------------------------------------------
(Updated March 17, 2014, 8:21 p.m.)
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
Try cleanup in Mesos
Diffs (updated)
-----
src/master/detector.cpp 3a8aaed
Diff: https://reviews.apache.org/r/19299/diff/
Testing
-------
Thanks,
Archana kumari
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Archana kumari <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/
-----------------------------------------------------------
(Updated March 17, 2014, 8:03 p.m.)
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
Try cleanup in Mesos
Diffs (updated)
-----
src/master/detector.cpp 3a8aaed
Diff: https://reviews.apache.org/r/19299/diff/
Testing
-------
Thanks,
Archana kumari
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Archana kumari <ar...@gmail.com>.
> On March 17, 2014, 7:26 p.m., Jie Yu wrote:
> > src/master/detector.cpp, line 117
> > <https://reviews.apache.org/r/19299/diff/3/?file=523303#file523303line117>
> >
> > One final nits:
> >
> > The indent here should be 4 spaces (instead of 2). Please refer to our code style guide.
> >
> > Sorry about the round trip!
I have indented it to be 1 tab so should I make it to be 2 tabs instead.
??
- Archana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/#review37434
-----------------------------------------------------------
On March 17, 2014, 7:15 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 7:15 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Try cleanup in Mesos
>
>
> Diffs
> -----
>
> src/master/detector.cpp 3a8aaed
>
> Diff: https://reviews.apache.org/r/19299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Jie Yu <yu...@gmail.com>.
> On March 17, 2014, 7:26 p.m., Jie Yu wrote:
> > src/master/detector.cpp, line 117
> > <https://reviews.apache.org/r/19299/diff/3/?file=523303#file523303line117>
> >
> > One final nits:
> >
> > The indent here should be 4 spaces (instead of 2). Please refer to our code style guide.
> >
> > Sorry about the round trip!
>
> Archana kumari wrote:
> I have indented it to be 1 tab so should I make it to be 2 tabs instead.
>
> ??
We never use tabs. Convert all tabs to 2 spaces please!
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/#review37434
-----------------------------------------------------------
On March 17, 2014, 7:15 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 7:15 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Try cleanup in Mesos
>
>
> Diffs
> -----
>
> src/master/detector.cpp 3a8aaed
>
> Diff: https://reviews.apache.org/r/19299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/#review37434
-----------------------------------------------------------
src/master/detector.cpp
<https://reviews.apache.org/r/19299/#comment68961>
One final nits:
The indent here should be 4 spaces (instead of 2). Please refer to our code style guide.
Sorry about the round trip!
- Jie Yu
On March 17, 2014, 7:15 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 7:15 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Try cleanup in Mesos
>
>
> Diffs
> -----
>
> src/master/detector.cpp 3a8aaed
>
> Diff: https://reviews.apache.org/r/19299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Archana kumari <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/
-----------------------------------------------------------
(Updated March 17, 2014, 7:15 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Assigning this review to Jie to shepherd through to commit.
-bmahler
Repository: mesos-git
Description
-------
Try cleanup in Mesos
Diffs
-----
src/master/detector.cpp 3a8aaed
Diff: https://reviews.apache.org/r/19299/diff/
Testing
-------
Thanks,
Archana kumari
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Archana kumari <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/
-----------------------------------------------------------
(Updated March 17, 2014, 6:25 p.m.)
Review request for mesos.
Repository: mesos-git
Description
-------
Try cleanup in Mesos
Diffs (updated)
-----
src/master/detector.cpp 3a8aaed
Diff: https://reviews.apache.org/r/19299/diff/
Testing
-------
Thanks,
Archana kumari
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Jiang Yan Xu <ya...@jxu.me>.
> On March 17, 2014, 10:22 a.m., Jie Yu wrote:
> > src/master/detector.cpp, line 116
> > <https://reviews.apache.org/r/19299/diff/2/?file=522992#file522992line116>
> >
> > Instead of breaking a string into two lines, I would suggest the following:
> >
> > return Error(
> > "Expecting a (chroot) path for ZooKeeper ('/' is not supported)");
Sure.
- Jiang Yan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/#review37406
-----------------------------------------------------------
On March 17, 2014, 10:12 a.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 10:12 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Try cleanup in Mesos
>
>
> Diffs
> -----
>
> src/master/detector.cpp 3a8aaed
>
> Diff: https://reviews.apache.org/r/19299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Archana kumari <ar...@gmail.com>.
> On March 17, 2014, 5:22 p.m., Jie Yu wrote:
> > src/master/detector.cpp, line 116
> > <https://reviews.apache.org/r/19299/diff/2/?file=522992#file522992line116>
> >
> > Instead of breaking a string into two lines, I would suggest the following:
> >
> > return Error(
> > "Expecting a (chroot) path for ZooKeeper ('/' is not supported)");
>
> Jiang Yan Xu wrote:
> Sure.
- Archana
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/#review37406
-----------------------------------------------------------
On March 17, 2014, 8:21 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 8:21 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Try cleanup in Mesos
>
>
> Diffs
> -----
>
> src/master/detector.cpp 3a8aaed
>
> Diff: https://reviews.apache.org/r/19299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/#review37406
-----------------------------------------------------------
src/master/detector.cpp
<https://reviews.apache.org/r/19299/#comment68918>
Instead of breaking a string into two lines, I would suggest the following:
return Error(
"Expecting a (chroot) path for ZooKeeper ('/' is not supported)");
- Jie Yu
On March 17, 2014, 5:12 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 5:12 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Try cleanup in Mesos
>
>
> Diffs
> -----
>
> src/master/detector.cpp 3a8aaed
>
> Diff: https://reviews.apache.org/r/19299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/#review37417
-----------------------------------------------------------
Bad patch!
Reviews applied: [19299]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern' [enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
zip_safe flag not set; analyzing archive contents...
master/detector.cpp:116:20: error: missing terminating " character [-Werror]
master/detector.cpp:116:7: error: missing terminating " character
master/detector.cpp:117:36: error: missing terminating " character [-Werror]
master/detector.cpp:117:4: error: missing terminating " character
master/detector.cpp: In static member function 'static Try<mesos::internal::MasterDetector*> mesos::internal::MasterDetector::create(const string&)':
master/detector.cpp:117:35: error: invalid use of incomplete type 'struct ZooKeeper'
./zookeeper/group.hpp:22:7: error: forward declaration of 'struct ZooKeeper'
master/detector.cpp:116:19: error: expected primary-expression before '(' token
master/detector.cpp:117:35: error: invalid use of incomplete type 'struct ZooKeeper'
./zookeeper/group.hpp:22:7: error: forward declaration of 'struct ZooKeeper'
master/detector.cpp:117:14: error: expected primary-expression before '(' token
master/detector.cpp:117:19: error: expected ')' before 'is'
master/detector.cpp:118:5: error: expected ';' before '}' token
cc1plus: all warnings being treated as errors
make[2]: *** [master/libmesos_no_3rdparty_la-detector.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 17, 2014, 5:12 p.m., Archana kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19299/
> -----------------------------------------------------------
>
> (Updated March 17, 2014, 5:12 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Try cleanup in Mesos
>
>
> Diffs
> -----
>
> src/master/detector.cpp 3a8aaed
>
> Diff: https://reviews.apache.org/r/19299/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Archana kumari
>
>
Re: Review Request 19299: TRy cleanup in Mesos
Posted by Archana kumari <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19299/
-----------------------------------------------------------
(Updated March 17, 2014, 5:12 p.m.)
Review request for mesos.
Repository: mesos-git
Description
-------
Try cleanup in Mesos
Diffs (updated)
-----
src/master/detector.cpp 3a8aaed
Diff: https://reviews.apache.org/r/19299/diff/
Testing
-------
Thanks,
Archana kumari